Fix go vendor #278
Open
Fix go vendor #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last commit [0] introduced a bump to grpc but did not perform the appropriate make vendor step. This commit fixes this. [0] https://github.com/k8snetworkplumbingwg/multus-dynamic-networks-controller/tree/0546691af236bf825d1822d2ad9e7d6a22e10088 Signed-off-by: Ram Lavi <[email protected]>
Add a step to run 'make vendor' to ensure the vendor directory is up-to-date, failing the workflow if changes are needed. Signed-off-by: Ram Lavi <[email protected]>
RamLavi
force-pushed
the
fix_go_vendor
branch
from
fc77c1c to
8f9298e
Compare
|
@oshoval any ideas why linter fails? |
|
Please try locally / retest unless you already did, and attach more info if exists / add artifact collector in case needed (not sure we need that deep, but sometimes required) |
|
@oshoval locally (my pc/hades04) running the lint is failing on other things, but the same happens when I run it on main branch so it's unrelated.. |
|
I see dependabot is still trying to bump gprc, maybe merging that will solve the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Former commit introduced a bump to grpc but did not perform the appropriate make vendor step.
This PR fixes this, and also adds a check to CI in order to prevent it from happening again.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer (optional):