Remove driver version check #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Panattoni <[email protected]>
SchSeba
reviewed
May 9, 2024
README.md
Outdated
| @@ -9,7 +9,10 @@ The SR-IOV Network Metrics Exporter is designed with the Kubernetes SR-IOV stack | |||
| The sysfs collector for Virtual Function telemetry supports NICs with drivers that implement the SR-IOV sysfs management interface e.g. ice, i40e, mlnx_en and mlnx_ofed. | |||
|
|
|||
| The netlink collector relies on driver support and a kernel version of 4.4 or higher. | |||
| To support netlink, we recommend these driver versions: an i40e driver of 2.11+ or higher for Intel® 700 series NICs and ice driver 1.2+ for Intel® 800 series NICs. | |||
| To support netlink, we recommend these driver versions: | |||
There was a problem hiding this comment.
maybe something about minimal supported driver version or something like that?
There was a problem hiding this comment.
I rephrased as:
The netlink collector relies on driver support and a kernel version of 4.4 or higher.
Also, the following minimum driver versions are required for this collector:
- `i40e` - 2.11+ for Intel® 700 series NICs
- `ice` - 1.2+ for Intel® 800 series NICs
- `mlx5_core` - 5.15+ for Mellanox NICs
does it sound better?
zeeke
force-pushed
the
remove-version-map
branch
2 times, most recently
from
12efd05 to
224ef7e
Compare
Avoid checking the driver version against a user defined map. If the netlink collector is not supported by the Physical Function, the next provided collector (e.g. `sysfs`) is used. Signed-off-by: Andrea Panattoni <[email protected]>
|
@Eoghan1232 please take a look at this |
Eoghan1232
approved these changes
May 20, 2024
This was referenced May 22, 2024
[metrics 1/x] Support
sriov-network-metrics-exporter
k8snetworkplumbingwg/sriov-network-operator#655
Merged
zeeke
added a commit
to zeeke/sriov-network-metrics-exporter
that referenced
this pull request
Jun 10, 2024
As a leftover of: - Remove driver version check k8snetworkplumbingwg#37 the daemonset deployment file must be updated removing related references. Signed-off-by: Andrea Panattoni <[email protected]>
Eoghan1232
pushed a commit
that referenced
this pull request
Jun 11, 2024
As a leftover of: - Remove driver version check #37 the daemonset deployment file must be updated removing related references. Signed-off-by: Andrea Panattoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid checking the driver version against a user
defined map. If the netlink collector is not supported by
the Physical Function, the next provided collector (e.g.
sysfs)is used.
superseeds:
drivers.yamlfile optional #35cc @Eoghan1232 , @SchSeba