Changing volume types: type: "Directory" to type: "DirectoryOrCreate" #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to avoid "hostPath type check failed" error. With this volume type, we can avoid "MountVolume.SetUp failed for volume "kubecgroup" : hostPath type check failed: /sys/fs/cgroup/cpuset/kubepods.slice/ is not a directory" This way if the volume directory is not present, the directory will be created. I tested in my deployment and it works well.
Eoghan1232
approved these changes
Sep 11, 2024
SchSeba
reviewed
Dec 31, 2024
There was a problem hiding this comment.
Hi @sigitp-git,
do you have an example system where you see this issue??
in general I am not in favor of creating folders in sysfs if this folder doesn't exist that means something is not really going to work with the metrics.
so better to failed instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing volume types: type: "Directory" to type: "DirectoryOrCreate" to avoid "hostPath type check failed" error.
With this volume type, we can avoid "MountVolume.SetUp failed for volume "kubecgroup" : hostPath type check failed: /sys/fs/cgroup/cpuset/kubepods.slice/ is not a directory"
This way if the volume directory is not present, the directory will be created.
I tested in my deployment and it works well.