This repository has been archived by the owner on Feb 4, 2023. It is now read-only.
Fixes to the Dark and Black themes #845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sai <[email protected]>
Signed-off-by: Sai <[email protected]>
|
Check previous PRs this has been rejected multiple times |
|
Well, it is currently 100% broken and this is a fix. If it doesn't get pulled, it's the app's and its users' loss, not mine. |
|
What do you mean by it's currently broken? It works on my devices. |
The queue card within the Now Playing UI is grey even if the app theme is set to AMOLED Black within the settings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Black theme now finally uses actual #000000 black throughout instead of it being half-grey.
Dark theme updated with darker shades of grey to give it a more modern look (similar shades of grey to that of Google's MD2.0 apps).