Improve bitcoin transaction #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KOLANICH
reviewed
Apr 20, 2019
| doc: | | ||
| Public key (bitcoin address of the recipient). | ||
| types: | ||
| der_signature: |
There was a problem hiding this comment.
there is already a spec for ASN.1
There was a problem hiding this comment.
Right. I will have a look when I get a chance. Thanks!
|
Relatively simple change, looks legit, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I would like to apply what I've learnt from #131 to #102.
This PR brings the following improvements:
lenas a prefix and not as a suffix as defined in the style guide.Thanks