Feature/cmake dependencies #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurpicz
requested changes
Oct 23, 2023
| ${fetch_content_supported_flags} | ||
| ) | ||
|
|
||
| function (ensure_googletest) |
There was a problem hiding this comment.
Maybe we should move utility functionality like this in a different file to keep the main CMakeLists.txt short.
| list(APPEND fetch_content_supported_flags EXCLUDE_FROM_ALL) | ||
| endif () | ||
|
|
||
| # Using CMake >= 3.24 we override find_package and it "just works". For older versions we simulate the same behavior by |
There was a problem hiding this comment.
Can we automatically test this for different CMake versions in our GitHub action, i.e., add different CMake versions to our build matrix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.