Type corrected in feature flags

kamu-data · Nov 28, 2024 · 318ff94 · 318ff94
1 parent 0b23c75
commit 318ff94
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 - Readme section: modified 'Run' button into a link
 - Hint extension for tile widget account
+### Fixed
+- Typo in feature flags (enableDatasetEnvVarsManagement)
+                                                  ^
 
 ## [0.31.0] - 2024-11-22
 ### Added
@@ -143,7 +146,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 - Added access token feature
 - Added environment variables and secrets for the dataset
-- Added new flag(enableDatasetEnvVarsManagment) in the runtime configuration
+- Added new flag(enableDatasetEnvVarsManagement) in the runtime configuration
 ### Fixed
 - Fixed bug with cache(Data tab) on the deployment version
 - Extended full source info for EthereumLogs(Metadata tab)

diff --git a/src/app/app-config.model.ts b/src/app/app-config.model.ts
@@ -21,7 +21,7 @@ export enum LoginMethod {
 export interface AppConfigFeatureFlags {
     enableLogout: boolean;
     enableScheduling: boolean;
-    enableDatasetEnvVarsManagment: boolean;
+    enableDatasetEnvVarsManagement: boolean;
     enableTermsOfService: boolean;
 }
 

diff --git a/src/app/app.component.ts b/src/app/app.component.ts
@@ -40,7 +40,7 @@ export class AppComponent extends BaseComponent implements OnInit {
     public static readonly DEFAULT_FEATURE_FLAGS: AppConfigFeatureFlags = {
         enableLogout: true,
         enableScheduling: true,
-        enableDatasetEnvVarsManagment: true,
+        enableDatasetEnvVarsManagement: true,
         enableTermsOfService: true,
     };
 

diff --git a/src/app/auth/login/login.component.spec.ts b/src/app/auth/login/login.component.spec.ts
@@ -42,7 +42,7 @@ describe("LoginComponent", () => {
     const MOCK_FEATURE_FLAGS = {
         enableLogout: true,
         enableScheduling: true,
-        enableDatasetEnvVarsManagment: true,
+        enableDatasetEnvVarsManagement: true,
         enableTermsOfService: true,
     };
 

diff --git a/src/app/components/app-header/app-header.component.spec.ts b/src/app/components/app-header/app-header.component.spec.ts
@@ -86,7 +86,7 @@ describe("AppHeaderComponent", () => {
         component.featureFlags = {
             enableLogout: true,
             enableScheduling: true,
-            enableDatasetEnvVarsManagment: true,
+            enableDatasetEnvVarsManagement: true,
             enableTermsOfService: true,
         };
         component.loginMethods = [LoginMethod.GITHUB, LoginMethod.PASSWORD];

diff --git a/src/app/components/data-access-panel/data-access-modal/data-access-modal.component.ts b/src/app/components/data-access-panel/data-access-modal/data-access-modal.component.ts
@@ -42,7 +42,7 @@ export class DataAccessModalComponent {
 
     public get showApiTokensLink(): boolean {
         return (
-            this.appConfigService.featureFlags.enableDatasetEnvVarsManagment &&
+            this.appConfigService.featureFlags.enableDatasetEnvVarsManagement &&
             this.loggedUserService.isAuthenticated &&
             this.datasetBasics.kind === DatasetKind.Root
         );

diff --git a/...taset-view/additional-components/dataset-settings-component/dataset-settings.component.ts b/...taset-view/additional-components/dataset-settings-component/dataset-settings.component.ts
@@ -66,7 +66,7 @@ export class DatasetSettingsComponent extends BaseComponent implements OnInit {
 
     public get showSecretsManagerTab(): boolean {
         return (
-            this.appConfigService.featureFlags.enableDatasetEnvVarsManagment &&
+            this.appConfigService.featureFlags.enableDatasetEnvVarsManagement &&
             this.activeTab === SettingsTabsEnum.VARIABLES_AND_SECRETS
         );
     }
@@ -104,7 +104,7 @@ export class DatasetSettingsComponent extends BaseComponent implements OnInit {
                 return this.datasetBasics.kind === DatasetKind.Root;
             case SettingsTabsEnum.VARIABLES_AND_SECRETS:
                 return (
-                    this.appConfigService.featureFlags.enableDatasetEnvVarsManagment &&
+                    this.appConfigService.featureFlags.enableDatasetEnvVarsManagement &&
                     this.datasetBasics.kind === DatasetKind.Root
                 );
             default:

diff --git a/src/assets/runtime-config.json b/src/assets/runtime-config.json
@@ -6,7 +6,7 @@
   "featureFlags": {
     "enableLogout": true,
     "enableScheduling": true,
-    "enableDatasetEnvVarsManagment": true,
+    "enableDatasetEnvVarsManagement": true,
     "enableTermsOfService": true
   },
   "grafanaLogs": {