Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type corrected in feature flags #484

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Type corrected in feature flags #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Readme section: modified 'Run' button into a link
- Hint extension for tile widget account
### Fixed
- Typo in feature flags (enableDatasetEnvVarsManagement)
^

## [0.31.0] - 2024-11-22
### Added
Expand Down Expand Up @@ -143,7 +146,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Added access token feature
- Added environment variables and secrets for the dataset
- Added new flag(enableDatasetEnvVarsManagment) in the runtime configuration
- Added new flag(enableDatasetEnvVarsManagement) in the runtime configuration
### Fixed
- Fixed bug with cache(Data tab) on the deployment version
- Extended full source info for EthereumLogs(Metadata tab)
Expand Down
2 changes: 1 addition & 1 deletion src/app/app-config.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export enum LoginMethod {
export interface AppConfigFeatureFlags {
enableLogout: boolean;
enableScheduling: boolean;
enableDatasetEnvVarsManagment: boolean;
enableDatasetEnvVarsManagement: boolean;
enableTermsOfService: boolean;
}

Expand Down
2 changes: 1 addition & 1 deletion src/app/app.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export class AppComponent extends BaseComponent implements OnInit {
public static readonly DEFAULT_FEATURE_FLAGS: AppConfigFeatureFlags = {
enableLogout: true,
enableScheduling: true,
enableDatasetEnvVarsManagment: true,
enableDatasetEnvVarsManagement: true,
enableTermsOfService: true,
};

Expand Down
2 changes: 1 addition & 1 deletion src/app/auth/login/login.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe("LoginComponent", () => {
const MOCK_FEATURE_FLAGS = {
enableLogout: true,
enableScheduling: true,
enableDatasetEnvVarsManagment: true,
enableDatasetEnvVarsManagement: true,
enableTermsOfService: true,
};

Expand Down
2 changes: 1 addition & 1 deletion src/app/components/app-header/app-header.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ describe("AppHeaderComponent", () => {
component.featureFlags = {
enableLogout: true,
enableScheduling: true,
enableDatasetEnvVarsManagment: true,
enableDatasetEnvVarsManagement: true,
enableTermsOfService: true,
};
component.loginMethods = [LoginMethod.GITHUB, LoginMethod.PASSWORD];
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/data-access-panel/data-access-modal/data-access-modal.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class DataAccessModalComponent {

public get showApiTokensLink(): boolean {
return (
this.appConfigService.featureFlags.enableDatasetEnvVarsManagment &&
this.appConfigService.featureFlags.enableDatasetEnvVarsManagement &&
this.loggedUserService.isAuthenticated &&
this.datasetBasics.kind === DatasetKind.Root
);
Expand Down
4 changes: 2 additions & 2 deletions ...taset-view/additional-components/dataset-settings-component/dataset-settings.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class DatasetSettingsComponent extends BaseComponent implements OnInit {

public get showSecretsManagerTab(): boolean {
return (
this.appConfigService.featureFlags.enableDatasetEnvVarsManagment &&
this.appConfigService.featureFlags.enableDatasetEnvVarsManagement &&
this.activeTab === SettingsTabsEnum.VARIABLES_AND_SECRETS
);
}
Expand Down Expand Up @@ -104,7 +104,7 @@ export class DatasetSettingsComponent extends BaseComponent implements OnInit {
return this.datasetBasics.kind === DatasetKind.Root;
case SettingsTabsEnum.VARIABLES_AND_SECRETS:
return (
this.appConfigService.featureFlags.enableDatasetEnvVarsManagment &&
this.appConfigService.featureFlags.enableDatasetEnvVarsManagement &&
this.datasetBasics.kind === DatasetKind.Root
);
default:
Expand Down
2 changes: 1 addition & 1 deletion src/assets/runtime-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"featureFlags": {
"enableLogout": true,
"enableScheduling": true,
"enableDatasetEnvVarsManagment": true,
"enableDatasetEnvVarsManagement": true,
"enableTermsOfService": true
},
"grafanaLogs": {
Expand Down