Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add global variable to mock node's global object #48

Closed
wants to merge 1 commit into from
Closed

fix: add global variable to mock node's global object #48

wants to merge 1 commit into from

Conversation

mzahor
Copy link

@mzahor mzahor commented Nov 17, 2015

This fixes issues with some node.js packages (like lodash v3) which use global object.

This fixes issues with some node.js packages (like lodash v3) which use global object.
@pkozlowski-opensource
Copy link
Member

Thnx for this PR. IMO it should be solved more like in #44.

#44 wasn't merged since it is lacking tests.

@mzahor
Copy link
Author

mzahor commented Nov 17, 2015

If I add tests to #44 will it be merged in?

@pkozlowski-opensource
Copy link
Member

If I add tests to #44 will it be merged in?

Yes, I would say so. IMO the change looks good but we need a test so we don't remove it accidentally in the future.

@mzahor mzahor closed this Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants