Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Asynchronous Configurations in the Config File's Docs #3788

Closed

Conversation

npetruzzelli
Copy link
Contributor

@jginsburgn
Copy link
Member

Hey @npetruzzelli !

Thanks for your PR.

Async configurations are already documented as per #3761.

I am closing this PR, but please tell me if I am missing something.

@jginsburgn jginsburgn closed this Apr 19, 2022
@npetruzzelli
Copy link
Contributor Author

@jginsburgn - I didn't think to look for the other PR's content when I rebased and updated the example. The important thing is that users have access to the information. As long as they aren't confused, then its a win.

It doesn't have to be as verbose as something I'd write to work. My personal opinion on promise vs async didn't make @nicojs 's work any less correct and isn't something I'd want to hold up either PR.

I'm sorry it took 10 days to respond in any form. Life, both in and out of work, hasn't given me a lot of time to respond quickly.

I don't think you missed anything. No objections to the closing of the PR.

@jginsburgn
Copy link
Member

@npetruzzelli ack. Thanks for your contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants