Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karmada config page (fix date,monaco editor and other bug) #89

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Aug 18, 2024

What type of PR is this?
/kind api-change
/kind design

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #75

Special notes for your reviewer:
@warjiang PR #79 was so messed up and conflict to main branch. Please suggest me how to make the code more efficient in your free time. Or am I in right path. Also suggest me if the UI/code needs to be changed.

Does this PR introduce a user-facing change?:

  • overview of the karmada components
  • restart the component
  • Check Status
  • uninstall/install new karmada components
  • view the log of karmada components
  • edit/view the components' raw manifest
    Preview GIF

final

@karmada-bot karmada-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to design. labels Aug 18, 2024
@karmada-bot karmada-bot requested review from jhnine and warjiang August 18, 2024 16:05
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign samzong for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 18, 2024
@axif0 axif0 changed the title fix date,monaco editor and other bug Karmada config page (fix date,monaco editor and other bug) Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to design. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration of karmada components.
2 participants