Optimize ByteArray serialization #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Before After |
|
Does this make it possible to re-enable most of integration tests? |
All of them pass actually 🤯 |
🦸 |
maciejka
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting rid of ByteArray completely would be a bit complicated, because that would change the way we serialize arguments and also utreexo outpoints (need to change bridge node also). Moreover, it would probably not give that much of upside because we'd need to fill partial words anyways.
Alternative approach is just a more optimal ByteArray serialization:
It might probably make sense to move some of the logic to corelib.
For block 839999: 238M steps => 36M steps