Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #498: Allow _count for joins & relations #499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbergwall2222
Copy link

No description provided.

@kepelrs
Copy link
Owner

kepelrs commented May 24, 2023

Hey, thanks for the submission. Something happened with the formatting and it is hard to review, think you could have a look at it?

Before merging this I'll also to add a couple tests and see if other Prisma aggregation functions are in order. If so, I'd possibly move them: instead of under joins, they could be under aggregate: string[] or something like that. Thoughts?

@khalibloo
Copy link

Any chance to get this PR moving along? I think aggregates is better than joins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants