bpf: Return error for missed kprobe multi bpf program execution #8322
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 2532608 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
b58ecc3 to
5c57fa7
Compare
|
Upstream branch: 859a7db |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/922649=>bpf-next
branch
from
e220b16 to
fd90378
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
5c57fa7 to
2410e16
Compare
|
Upstream branch: f44275e |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/922649=>bpf-next
branch
from
fd90378 to
70bdb91
Compare
When kprobe multi bpf program can't be executed due to recursion check, we currently return 0 (success) to fprobe layer where it's ignored for standard kprobe multi probes. For kprobe session the success return value will make fprobe layer to install return probe and try to execute it as well. But the return session probe should not get executed, because the entry part did not run. FWIW the return probe bpf program most likely won't get executed, because its recursion check will likely fail as well, but we don't need to run it in the first place.. also we can make this clear and obvious. It also affects missed counts for kprobe session program execution, which are now doubled (extra count for not executed return probe). Signed-off-by: Jiri Olsa <[email protected]> Acked-by: Masami Hiramatsu (Google) <[email protected]>
Adding kprobe.session probe to bpf_kfunc_common_test that misses bpf program execution due to recursion check and making sure it increases the program missed count properly. Signed-off-by: Jiri Olsa <[email protected]>
|
Upstream branch: f44275e |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/922649=>bpf-next
branch
from
70bdb91 to
a1fa839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Return error for missed kprobe multi bpf program execution
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=922649