config: rt-tests: fix MLOCKALL getting set to True #2668
Conversation
musamaanjum
force-pushed
the
fix-pi-stress
branch
from
cffd491 to
79c6b9d
Compare
|
Let's confirm from the execution results if this works. |
|
This fix didn't work: https://lava.collabora.dev/scheduler/job/15747114 @pawiecz please can you help solve this issue? In job (https://lava.collabora.dev/scheduler/job/15747239), I've manually added double quotes around true and job worked fine. |
musamaanjum
force-pushed
the
fix-pi-stress
branch
from
79c6b9d to
875d144
Compare
@pawiecz Please have a look. |
|
Also: timeout for this test suite has to be extended to provide some buffer for initialization - it shouldn't be equal to the requested test duration. |
When MLOCKALL is set to 'true', the lava job has MLOCKALL becomes true [1] which in turn translates to "True" while job execution [2]. It causes error as the test expects true instead of True. ./pi-stress.sh -D 60s -m True -r false -w hackbench ./pi-stress.sh: 37: True: not found Fix it by using double quotes inside single quotes. - First set of quotations allows Jinja template engine to treat it as a string - Second set is for LAVA to also treat is as string and prevent YAML parser from making it a bool [3] is successful job after this change. [1] https://lava.collabora.dev/scheduler/job/15562666/definition#defline43 [2] https://lava.collabora.dev/scheduler/job/15562666#L220 [3] https://lava.collabora.dev/scheduler/job/15790058 Relates kernelci/kernelci-project#439 Co-authored-by: Paweł Wieczorek <[email protected]> Signed-off-by: Muhammad Usama Anjum <[email protected]>
musamaanjum
force-pushed
the
fix-pi-stress
branch
from
0b3e3d2 to
475ece0
Compare
@pawiecz we had probably discussed this in some meetings that it is okay to have the same timeouts. Or I may be mistaken. Currently, the total test duration is set to 10 minutes and the test's execution is also set to 10 minutes. Should we reduce the test duration by 30 or 60 seconds? |
|
Result: https://lava.collabora.dev/scheduler/job/15790240 @nuclearcat let's merge this PR. |
Let me give an example:
Due to these slight delays it might not be able to finish successfully. Providing a slight margin (e.g. 11 minutes instead of 10 for a test expected to go for 10 minutes) could reduce flakiness
I'm not sure how long this test case should run to provide meaningful results 😢 |
When MLOCKALL is set to 'true', the lava job has MLOCKALL becomes true [1] which in turn translates to "True" while job execution [2]. It causes error as the test expects true instead of True.
./pi-stress.sh -D 60s -m True -r false -w hackbench
./pi-stress.sh: 37: True: not found
Fix it by using double quotes instead.
[1] https://lava.collabora.dev/scheduler/job/15562666/definition#defline43
[2] https://lava.collabora.dev/scheduler/job/15562666#L220