fix(helper.py): Handle better exception in kbuild #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observed error with pod crash:
```
11/27/2024 10:24:52 PM UTC [ERROR] Traceback (most recent call last):
File "/home/kernelci/pipeline/src/base.py", line 69, in run
status = self._run(context)
^^^^^^^^^^^^^^^^^^
File "/home/kernelci/pipeline/./src/scheduler.py", line 296, in _run
self._run_job(job, runtime, platform, input_node)
File "/home/kernelci/pipeline/./src/scheduler.py", line 80, in _run_job
node = self._api_helper.create_job_node(job_config, input_node,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/kernelci/api/helper.py", line 456, in create_job_node
job_node['data'] = platform.format_params(job_node['data'], extra_args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/kernelci/config/base.py", line 167, in format_params
return _format_dict_strings(param, args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/kernelci/config/base.py", line 79, in _format_dict_strings
param[key] = _format_dict_strings(param[key], fmap)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/kernelci/config/base.py", line 79, in _format_dict_strings
param[key] = _format_dict_strings(param[key], fmap)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/kernelci/config/base.py", line 74, in _format_dict_strings
param = param.format_map(fmap)
^^^^^^^^^^^^^^^^^^^^^^
ValueError: unmatched '{' in format spec
```
We can handle it without crash.
Signed-off-by: Denys Fedoryshchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed error with pod crash:
We can handle it without crash.