Announcing new Keycloak Ui component libraries #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edewit
force-pushed
the
component-lib
branch
2 times, most recently
from
a4a2b0f to
bbfbdd9
Compare
Signed-off-by: Erik Jan de Wit <[email protected]>
edewit
force-pushed
the
component-lib
branch
from
bbfbdd9 to
4e25a16
Compare
ssilvert
reviewed
Sep 5, 2024
ssilvert
requested changes
Sep 5, 2024
There was a problem hiding this comment.
@edewit I tried it out again and everything looks good except using the jar generated with Maven.
I suggested a couple of minor changes and some text about composable UI. There might be a better way to talk about composable UI and how it affects backward compatibility. Feel free to change or throw away what I suggested.
Co-authored-by: Stan Silvert <[email protected]> Signed-off-by: Erik Jan de Wit <[email protected]>
Co-authored-by: Stan Silvert <[email protected]> Signed-off-by: Erik Jan de Wit <[email protected]>
Co-authored-by: Stan Silvert <[email protected]> Signed-off-by: Erik Jan de Wit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.