Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/review deploy #67

Merged
merged 3 commits into from
Sep 28, 2024
Merged

Chore/review deploy #67

merged 3 commits into from
Sep 28, 2024

Conversation

kfastov
Copy link
Owner

@kfastov kfastov commented Sep 28, 2024

Ran through entire deploy script, sorting out the blockers and fixing the following alongside:

  1. Move contract address saving feature from Solidity to JS
  2. Simplify variable names (ethereumEtherscanApiKey -> etherScanApiKey and so on)
  3. Add a getter for the verifier URL (for Linea)
  4. Fix minor bug in parsing output of Forge scripts (entire data was used inside a loop instead of the loop variable)
  5. Cleaner and more informative messages in deploy script (e.g. show contract addresses, summary of each stage)
  6. Create environment files for network-dependent configuration like addresses of important contracts (used separate json configs for that before, now removed)
    Problems that I couldn't fix yet:
  7. Deploy script in the reference repo has much more functionality (mainnet, devnet deployment). This one was currently only tested on Sepolia.
  8. Contract verification failed because of Etherscan was unabled to compile the sources on their side (probably need to simplify our import paths):
% forge verify-contract 0x4f71bB382A119d0545C28FB532Cad673aF321C9F src/LineaWorldID.sol:LineaWorldID --etherscan-api-key <CENSORED> --verifier-url https://api-sepolia.lineascan.build/api --watch
Start verifying contract `0x4f71bB382A119d0545C28FB532Cad673aF321C9F` deployed on sepolia

Submitting verification for [src/LineaWorldID.sol:LineaWorldID] 0x4f71bB382A119d0545C28FB532Cad673aF321C9F.
Submitted contract for verification:
        Response: `OK`
        GUID: `bgjrh92uephaqvbtcsbiwfckrz9dci3gmkbgfdqyznm9zdk41h`
        URL: https://sepolia.etherscan.io/address/0x4f71bb382a119d0545c28fb532cad673af321c9f
Contract verification status:
Response: `NOTOK`
Details: `Pending in queue`
Contract verification status:
Response: `NOTOK`
Details: `Fail - Unable to verify. Solidity Compilation Error: Source "src/interfaces/ISemaphoreVerifier.sol" not found: File not found. Searched the following locations: "".`
Error: 
Checking verification result failed

Context:
- Contract failed to verify.

Current deployments:

✔ LineaWorldID already deployed at 0x5d676D93ffE4dC07805a780531a559b08cC3564d
✔ LineaStateBridge already deployed at 0x64A96eED1dA15FCFb0874D82F7D7C6ea3Fda6aEf

@kfastov kfastov merged commit 5ac882e into main Sep 28, 2024
3 checks passed
@kfastov kfastov deleted the chore/review-deploy branch September 28, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant