Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.go #513

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Update main.go #513

wants to merge 14 commits into from

Conversation

NxPKG
Copy link
Contributor

@NxPKG NxPKG commented Oct 31, 2024

Addresses issue: #

Changes proposed in this pull request:

  • Change 1
  • Change 2
  • Change 3

Summary by Sourcery

Enhancements:

  • Add filtering capability to reports in the ingest process.

Signed-off-by: NxPKG <[email protected]>
Copy link

sourcery-ai bot commented Oct 31, 2024

Reviewer's Guide by Sourcery

The pull request adds filtering functionality to the report ingestion process. The implementation adds a filter step after stripping the report ID but before preparing the destination path.

Sequence diagram for the report ingestion process with filtering

sequenceDiagram
    participant Context as ctx
    participant Source as s
    participant Report as r
    participant Config as c
    participant FilePath as filepath
    participant Log as log

    Context->>Source: Get Source
    Source->>Report: Get Report
    Report->>Report: StripID()
    Report->>Source: ApplyFilter(s.Filter())
    alt Filter Applied
        Report->>FilePath: Prepare destination path
        FilePath->>Log: Log destination path
    end
Loading

File-Level Changes

Change Details Files
Added report filtering during the ingestion process
  • Added a call to ApplyFilter using the source's filter configuration
  • Placed filtering step after ID stripping and before destination path preparation
cmd/ingest/main.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @NxPKG - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide a more descriptive PR title and fill out the PR description template properly. This helps reviewers understand the context and purpose of the changes.
  • Consider adding error handling for the ApplyFilter call if the operation can fail.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant