Update workspacePublicAccessDisabled.js

[gitworkflows]

User description

Notes for Reviewers

This PR fixes #

Signed commits

• Yes, I signed my commits.

---

PR Type

enhancement

---

Description

• Updated the realtime_triggers in the Azure Machine Learning workspace configuration to use the correct service identifiers, changing from microsoftcognitiveservices to microsoft:machinelearningservices.
• This change ensures that the triggers accurately reflect the operations for writing and deleting workspaces in Azure Machine Learning services.

---

Changes walkthrough 📝

	Relevant files
Enhancement	workspacePublicAccessDisabled.js Update Azure Machine Learning workspace triggers                  plugins/azure/machinelearning/workspacePublicAccessDisabled.js Updated realtime_triggers to reflect correct Azure Machine Learning services. Changed triggers from microsoftcognitiveservices to microsoft:machinelearningservices. +2/-2

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Summary by Sourcery

Fix the realtime_triggers in the Azure Machine Learning workspacePublicAccessDisabled.js to ensure correct monitoring of workspace write and delete operations.

Bug Fixes:

• Correct the realtime_triggers for Azure Machine Learning workspaces to use the appropriate Microsoft Machine Learning Services triggers.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates the workspacePublicAccessDisabled.js file in the Azure Machine Learning plugin. The main change is the correction of the realtime_triggers array, replacing the cognitive services triggers with the correct machine learning services triggers.

File-Level Changes

Change	Details	Files
Update realtime triggers for Azure Machine Learning workspaces	Replace 'microsoftcognitiveservices:accounts:write' with 'microsoft:machinelearningservices:workspaces:write' Replace 'microsoftcognitiveservices:accounts:delete' with 'microsoft:machinelearningservices:workspaces:delete'	plugins/azure/machinelearning/workspacePublicAccessDisabled.js

Sequence Diagram

No sequence diagram generated.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ No key issues to review

[codiumai-pr-agent-free]

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Implement a check for the 'publicNetworkAccess' property of the workspace Consider adding a check for the 'publicNetworkAccess' property of the workspace to ensure it's set to 'Disabled'. This will align the implementation with the module's description and recommended action. plugins/azure/machinelearning/workspacePublicAccessDisabled.js [16-18] run: function(cache, settings, callback) { const results = []; const source = {}; + const checkPublicNetworkAccess = (workspace) => { + return workspace.properties && workspace.properties.publicNetworkAccess === 'Disabled'; + }; Apply this suggestion Suggestion importance[1-10]: 9 Why: This suggestion aligns the implementation with the module's description and recommended action by ensuring that the workspace's public network access is disabled, which is crucial for security.	9
Best practice	Add the specific API call for retrieving workspace properties to the 'apis' array Update the apis array to include the specific API call for retrieving workspace properties, which is likely needed to check the public network access status. plugins/azure/machinelearning/workspacePublicAccessDisabled.js [13] -apis: ['machineLearning:listWorkspaces'], +apis: ['machineLearning:listWorkspaces', 'machineLearning:getWorkspace'], Apply this suggestion Suggestion importance[1-10]: 8 Why: Including the specific API call for retrieving workspace properties is a best practice that ensures the necessary data is available to verify the public network access status, improving the module's functionality.	8

💡 Need additional feedback ? start a PR chat

[sourcery-ai]

Hey @gitworkflows - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}