Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202411-rc add #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

202411-rc add #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-clang-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:

runs-on: ci-clang-scan
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-cmake-options.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:

runs-on: ci-gcc10
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-cov-linux-report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
build:

runs-on: ci-kw-linux
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-cov-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:

runs-on: ci-kw-linux
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-cov-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:

runs-on: ci-kw-linux
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-cov-windows-report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
build:

runs-on: ci-kw-windows
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Potential issue

Repository condition is consistently applied but needs to be inverted

The verification shows that all CI workflows (except clang_scan.yml) use the same condition github.repository != 'khulnasoft/pcm', which means these workflows will run only on forks but not on the main repository. This is likely incorrect as CI workflows should typically run on the main repository.

  • The condition should be inverted to github.repository == 'khulnasoft/pcm' in all CI workflow files to ensure they run on the main repository
  • The old clang_scan.yml file shows the correct pattern with github.repository == 'intel/pcm', confirming that CI workflows were previously configured to run on the main repository
🔗 Analysis chain

Verify the workflow execution condition

The condition if: ${{ github.repository != 'khulnasoft/pcm' }} means this workflow will NOT run on the 'khulnasoft/pcm' repository. Is this the intended behavior? The workflow will only execute on forks or other repositories.

Let's verify the repository references across other workflow files:

If this workflow should run on the main repository, the condition should be removed or inverted.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check repository conditions across all workflow files
# Expected: Consistent repository reference patterns

# Search for repository conditions in workflow files
echo "Checking repository conditions in workflows:"
rg -A 1 "github.repository" .github/workflows/

Length of output: 2665


steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-cov-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:

runs-on: ci-kw-windows
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-cpack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permissions:
jobs:
job-build1:
runs-on: ci-gcc9
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Inconsistency found in clang_scan.yml workflow condition

The repository migration from 'intel/pcm' to 'khulnasoft/pcm' is incomplete. While most workflow files have been updated correctly, there's one remaining issue:

  • .github/workflows/clang_scan.yml still uses the old condition if: ${{ github.repository == 'intel/pcm' }}
🔗 Analysis chain

LGTM: Repository condition updated correctly

The condition update from 'intel/pcm' to 'khulnasoft/pcm' aligns with the repository migration.

Let's verify consistency across all workflow files:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if all workflow files consistently use 'khulnasoft/pcm' in their conditions

# Search for any remaining references to 'intel/pcm' in workflow files
echo "Checking for any remaining 'intel/pcm' references:"
rg "intel/pcm" .github/workflows/

# Search for consistent usage of 'khulnasoft/pcm' in workflow files
echo "Verifying 'khulnasoft/pcm' usage:"
rg "khulnasoft/pcm" .github/workflows/

Length of output: 2096


steps:
- name: Harden Runner
Expand Down Expand Up @@ -40,7 +40,7 @@ jobs:

job-build2:
runs-on: ci-test
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-cppcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:

runs-on: ci-cppcheck
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Repository reference inconsistency found in workflow files

The repository name change is not consistent across all workflow files. While most workflows have been updated to 'khulnasoft/pcm', the following issue was found:

  • .github/workflows/clang_scan.yml still contains the old reference 'intel/pcm' in its condition: if: ${{ github.repository == 'intel/pcm' }}
🔗 Analysis chain

Verify repository name consistency across workflows

The repository name change from 'intel/pcm' to 'khulnasoft/pcm' aligns with the project rebranding. Let's verify this change is consistent across all workflow files.

Let's check the content of clang_scan.yml since it still contains a reference to 'intel/pcm':

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining references to 'intel/pcm' in workflow files
# and verify consistency of repository references

echo "Checking for any remaining 'intel/pcm' references in workflow files..."
rg -l "intel/pcm" .github/workflows/

echo "Listing all repository conditions in workflow files for consistency check..."
rg -A 1 "github.repository !=" .github/workflows/

Length of output: 2843

Script:

#!/bin/bash
# Check the content of clang_scan.yml for intel/pcm references
cat .github/workflows/clang_scan.yml

Length of output: 1700

🧰 Tools
🪛 yamllint (1.35.1)

[error] 16-16: trailing spaces

(trailing-spaces)


steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-fuzz-micro.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permissions:
jobs:
fuzz:
runs-on: ci-test
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-fuzz-short.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions:
jobs:
fuzz:
runs-on: ci-test
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Potential issue

Repository condition logic is consistently applied but needs attention

The repository condition github.repository != 'khulnasoft/pcm' is consistently used across all CI workflow files except clang_scan.yml, which uses the opposite condition with intel/pcm. This reveals two issues:

  • All CI workflows are configured to run on every repository except khulnasoft/pcm, which is likely not the intended behavior for CI infrastructure
  • The clang_scan.yml workflow still references the old repository name intel/pcm and uses opposite logic
🔗 Analysis chain

Verify the repository condition logic

The condition github.repository != 'khulnasoft/pcm' means this workflow will run for all repositories except khulnasoft/pcm. Is this the intended behavior? Usually, we want workflows to run only for the main repository and its forks.

Let's verify the consistency of repository conditions across all workflow files:

Consider changing to:

-    if: ${{ github.repository != 'khulnasoft/pcm' }}
+    if: ${{ github.repository == 'khulnasoft/pcm' }}
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check repository conditions in all workflow files
# Expected: All workflow files should have consistent repository checks

# Search for repository conditions in workflow files
echo "Checking repository conditions in workflow files:"
rg -l "github.repository" .github/workflows/ | while read -r file; do
  echo "=== $file ==="
  rg "github.repository" "$file" -A 1 -B 1
done

Length of output: 5085


steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-fuzz.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:
jobs:
fuzz:
runs-on: ci-test
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-gcc10.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:

runs-on: ci-gcc10
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-gcc7.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:

runs-on: ci-gcc9
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-gcc9.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:

runs-on: ci-gcc9
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: The condition will prevent CI from running on the main repository

The condition github.repository != 'khulnasoft/pcm' means this workflow will skip running on the khulnasoft/pcm repository. This appears to be incorrect as we would want the CI to run on the main repository, not skip it.

Consider one of these fixes:

  1. Remove the condition entirely if you want the workflow to run on all repositories
  2. Invert the condition to github.repository == 'khulnasoft/pcm' if you want it to run only on the main repository
  3. If the intent is to skip specific forks, list those repositories explicitly
-    if: ${{ github.repository != 'khulnasoft/pcm' }}
+    if: ${{ github.repository == 'khulnasoft/pcm' }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if: ${{ github.repository != 'khulnasoft/pcm' }}
if: ${{ github.repository == 'khulnasoft/pcm' }}


steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:

runs-on: ci-test
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-windows-ip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
build:

runs-on: ci-windows
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}

steps:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
build:

runs-on: ci-windows
if: ${{ github.repository != 'intel/pcm' }}
if: ${{ github.repository != 'khulnasoft/pcm' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Potential issue

Critical: All CI workflows are configured to skip the main repository

This is a critical issue affecting the entire CI pipeline. The verification reveals that all workflow files (except clang_scan.yml) contain the condition if: ${{ github.repository != 'khulnasoft/pcm' }}, which means:

  • None of the CI workflows will run on the main repository
  • This includes critical workflows for:
    • Windows builds (ci-windows.yml, ci-windows-ip.yml)
    • Linux builds (ci-gcc*.yml)
    • Test coverage (ci-cov-*.yml)
    • Fuzzing (ci-fuzz*.yml)
    • Package generation (ci-cpack.yml)
    • Code analysis (ci-cppcheck.yml, ci-clang-scan.yml)

The consistent pattern across all workflows suggests this might be a systematic error in the repository migration from intel/pcm to khulnasoft/pcm. The conditions should be reversed to == instead of != to ensure CI runs on the main repository.

🔗 Analysis chain

Verify the workflow condition - potential critical issue

The condition if: ${{ github.repository != 'khulnasoft/pcm' }} will prevent this workflow from running on the main repository. This seems counterintuitive as it means Windows builds will never run on khulnasoft/pcm.

Questions for clarification:

  1. Is this intentional? Are Windows builds handled differently for the main repository?
  2. If not intentional, should this condition be reversed to == instead of !=?

Let's verify the conditions across other workflow files:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check conditions in other workflow files to understand the pattern
# Expected: Find similar conditions in other workflow files to understand if this is a consistent pattern

echo "Checking conditions in all workflow files:"
rg -A 1 "if: " .github/workflows/

Length of output: 2650


steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ We warmly welcome contributions from everyone. If you wish to submit patches, pl
License
--------------------------------------------------------------------------------

Intel® PCM is licensed using a [BSD 3-clause license](https://github.com/intel/pcm/blob/master/LICENSE). All code submitted to the project is required to carry that license.
Intel® PCM is licensed using a [BSD 3-clause license](https://github.com/khulnasoft/pcm/blob/master/LICENSE). All code submitted to the project is required to carry that license.

--------------------------------------------------------------------------------
Coding Style
Expand Down
20 changes: 10 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
Intel® Performance Counter Monitor (Intel® PCM)
--------------------------------------------------------------------------------

[![CodeQL](https://github.com/intel/pcm/actions/workflows/codeql.yml/badge.svg?branch=master)](https://github.com/intel/pcm/security/code-scanning/tools/CodeQL/status)
[![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/intel/pcm/badge)](https://securityscorecards.dev/viewer/?uri=github.com/intel/pcm)
[![CodeQL](https://github.com/khulnasoft/pcm/actions/workflows/codeql.yml/badge.svg?branch=master)](https://github.com/khulnasoft/pcm/security/code-scanning/tools/CodeQL/status)
[![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/khulnasoft/pcm/badge)](https://securityscorecards.dev/viewer/?uri=github.com/intel/pcm)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Inconsistent repository reference in OpenSSF Scorecard link

The badge URL has been updated to use khulnasoft/pcm, but the viewer URL still points to intel/pcm. This should be updated for consistency.

[![OpenSSF Best Practices](https://www.bestpractices.dev/projects/8652/badge)](https://www.bestpractices.dev/projects/8652)

[PCM Tools](#pcm-tools) | [Building PCM](#building-pcm-tools) | [Downloading Pre-Compiled PCM](#downloading-pre-compiled-pcm-tools) | [FAQ](#frequently-asked-questions-faq) | [API Documentation](#pcm-api-documentation) | [Environment Variables](#pcm-environment-variables) | [Compilation Options](#custom-compilation-options)
Expand All @@ -18,11 +18,11 @@ We welcome bug reports and enhancement requests, which can be submitted via the
Current Build Status
--------------------------------------------------------------------------------

- Linux: [![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/intel/pcm/linux_make.yml?branch=master)](https://github.com/intel/pcm/actions/workflows/linux_make.yml?query=branch%3Amaster)
- Linux: [![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/khulnasoft/pcm/linux_make.yml?branch=master)](https://github.com/khulnasoft/pcm/actions/workflows/linux_make.yml?query=branch%3Amaster)
- Windows: [![Build status](https://ci.appveyor.com/api/projects/status/github/intel/pcm?branch=master&svg=true)](https://ci.appveyor.com/project/opcm/pcm)
- FreeBSD: [![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/intel/pcm/freebsd_build.yml?branch=master)](https://github.com/intel/pcm/actions/workflows/freebsd_build.yml?query=branch%3Amaster)
- OS X: [![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/intel/pcm/macosx_build.yml?branch=master)](https://github.com/intel/pcm/actions/workflows/macosx_build.yml?query=branch%3Amaster)
- Docker container: [![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/intel/pcm/docker.yml?branch=master)](doc/DOCKER_README.md)
- FreeBSD: [![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/khulnasoft/pcm/freebsd_build.yml?branch=master)](https://github.com/khulnasoft/pcm/actions/workflows/freebsd_build.yml?query=branch%3Amaster)
- OS X: [![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/khulnasoft/pcm/macosx_build.yml?branch=master)](https://github.com/khulnasoft/pcm/actions/workflows/macosx_build.yml?query=branch%3Amaster)
- Docker container: [![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/khulnasoft/pcm/docker.yml?branch=master)](doc/DOCKER_README.md)

--------------------------------------------------------------------------------
PCM Tools
Expand All @@ -32,19 +32,19 @@ PCM provides a number of command-line utilities for real-time monitoring:

- **pcm** : basic processor monitoring utility (instructions per cycle, core frequency (including Intel(r) Turbo Boost Technology), memory and Intel(r) Quick Path Interconnect bandwidth, local and remote memory bandwidth, cache misses, core and CPU package sleep C-state residency, core and CPU package thermal headroom, cache utilization, CPU and memory energy consumption)

![pcm output](https://github.com/intel/pcm/assets/25432609/88485ff5-dc7c-4a1c-974f-8396f03829dc)
![pcm output](https://github.com/khulnasoft/pcm/assets/25432609/88485ff5-dc7c-4a1c-974f-8396f03829dc)

- **pcm-sensor-server** : pcm collector exposing metrics over http in JSON or Prometheus (exporter text based) format ([how-to](doc/PCM-EXPORTER.md)). Also available as a [docker container](doc/DOCKER_README.md). More info about Global PCM events is [here](doc/PCM-SENSOR-SERVER-README.md).
- **pcm-memory** : monitor memory bandwidth (per-channel and per-DRAM DIMM rank)
![pcm-memory output](https://raw.githubusercontent.com/wiki/intel/pcm/pcm-memory.x.JPG)
![pcm-memory output](https://raw.githubusercontent.com/wiki/khulnasoft/pcm/pcm-memory.x.JPG)
- **pcm-accel** : [monitor Intel® In-Memory Analytics Accelerator (Intel® IAA), Intel® Data Streaming Accelerator (Intel® DSA) and Intel® QuickAssist Technology (Intel® QAT) accelerators](doc/PCM_ACCEL_README.md)
![image](https://user-images.githubusercontent.com/25432609/218480696-42ade94f-e0c3-4000-9dd8-39a0e75a210e.png)

- **pcm-latency** : monitor L1 cache miss and DDR/PMM memory latency
- **pcm-pcie** : monitor PCIe bandwidth per-socket
- **pcm-iio** : monitor PCIe bandwidth per PCIe device

![pcm-iio output](https://raw.githubusercontent.com/wiki/intel/pcm/pcm-iio.png)
![pcm-iio output](https://raw.githubusercontent.com/wiki/khulnasoft/pcm/pcm-iio.png)
- **pcm-numa** : monitor local and remote memory accesses
- **pcm-power** : monitor sleep and energy states of processor, Intel(r) Quick Path Interconnect, DRAM memory, reasons of CPU frequency throttling and other energy-related metrics
- **pcm-tsx**: monitor performance metrics for Intel(r) Transactional Synchronization Extensions
Expand All @@ -54,7 +54,7 @@ PCM provides a number of command-line utilities for real-time monitoring:

Graphical front ends:
- **pcm Grafana dashboard** : front-end for Grafana (in [scripts/grafana](scripts/grafana) directory). Full Grafana Readme is [here](scripts/grafana/README.md)
![pcm grafana output](https://raw.githubusercontent.com/wiki/intel/pcm/pcm-dashboard.png)
![pcm grafana output](https://raw.githubusercontent.com/wiki/khulnasoft/pcm/pcm-dashboard.png)
- **pcm-sensor** : front-end for KDE KSysGuard
- **pcm-service** : front-end for Windows perfmon

Expand Down
6 changes: 3 additions & 3 deletions _service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<service name="download_url">
<param name="host">github.com</param>
<param name="protocol">https</param>
<param name="path">/intel/pcm/archive/master.zip</param>
<param name="path">/khulnasoft/pcm/archive/master.zip</param>
</service>
<service name="download_url">
<param name="host">github.com</param>
<param name="protocol">https</param>
<param name="path">/intel/pcm/archive/master.tar.gz</param>
<param name="path">/khulnasoft/pcm/archive/master.tar.gz</param>
</service>
<service name="download_url"><param name="host">raw.githubusercontent.com</param><param name="protocol">https</param><param name="path">/intel/pcm/master/pcm.spec</param></service></services>
<service name="download_url"><param name="host">raw.githubusercontent.com</param><param name="protocol">https</param><param name="path">/khulnasoft/pcm/master/pcm.spec</param></service></services>
6 changes: 3 additions & 3 deletions doc/DOCKER_README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ How To Run Intel(r) Performance Counter Monitor Server Container from GitHub Con

As root user:
1. ``modprobe msr``
2. ``docker run -d --name pcm --privileged -p 9738:9738 ghcr.io/intel/pcm`` (GitHub Container repository) or ``docker run -d --name pcm --privileged -p 9738:9738 opcm/pcm`` (Dockerhub repository)
- the container can also be run with limited capabilities without the privileged mode: ``docker run -d --name pcm --cap-add=SYS_ADMIN --cap-add=SYS_RAWIO --device=/dev/cpu --device=/dev/mem -v /sys/firmware/acpi/tables/MCFG:/pcm/sys/firmware/acpi/tables/MCFG:ro -v /proc/bus/pci/:/pcm/proc/bus/pci/ -v /proc/sys/kernel/nmi_watchdog:/pcm/proc/sys/kernel/nmi_watchdog -v /sys:/sys:rw -p 9738:9738 ghcr.io/intel/pcm`` (there is also a docker-compose file containing these options: https://raw.githubusercontent.com/intel/pcm/master/docker-compose.yml)
2. ``docker run -d --name pcm --privileged -p 9738:9738 ghcr.io/khulnasoft/pcm`` (GitHub Container repository) or ``docker run -d --name pcm --privileged -p 9738:9738 opcm/pcm`` (Dockerhub repository)
- the container can also be run with limited capabilities without the privileged mode: ``docker run -d --name pcm --cap-add=SYS_ADMIN --cap-add=SYS_RAWIO --device=/dev/cpu --device=/dev/mem -v /sys/firmware/acpi/tables/MCFG:/pcm/sys/firmware/acpi/tables/MCFG:ro -v /proc/bus/pci/:/pcm/proc/bus/pci/ -v /proc/sys/kernel/nmi_watchdog:/pcm/proc/sys/kernel/nmi_watchdog -v /sys:/sys:rw -p 9738:9738 ghcr.io/khulnasoft/pcm`` (there is also a docker-compose file containing these options: https://raw.githubusercontent.com/khulnasoft/pcm/master/docker-compose.yml)

This will start pcm-sensor-server container exposing CPU metrics from the whole system at port 9738

The URLs of the docker container repositories:
- https://github.com/intel/pcm/pkgs/container/pcm
- https://github.com/khulnasoft/pcm/pkgs/container/pcm
- https://hub.docker.com/r/opcm/pcm
4 changes: 2 additions & 2 deletions doc/LATENCY-OPTIMIZED-MODE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ Should this BIOS option be unavailable or if there is a preference to change the

|Platform |Script Type| URL |
|------------------|-----------|---------------------------------------------------------------------|
|Linux/FreeBSD/UNIX|bash | https://github.com/intel/pcm/blob/master/scripts/bhs-power-mode.sh |
|Windows |powershell | https://github.com/intel/pcm/blob/master/scripts/bhs-power-mode.ps1 |
|Linux/FreeBSD/UNIX|bash | https://github.com/khulnasoft/pcm/blob/master/scripts/bhs-power-mode.sh |
|Windows |powershell | https://github.com/khulnasoft/pcm/blob/master/scripts/bhs-power-mode.ps1 |
Comment on lines +26 to +27
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Repository URLs in documentation need to be updated for consistency

Several documentation files still contain references to the old intel/pcm repository that need to be updated to khulnasoft/pcm:

  • doc/PCM-EXPORTER.md: Contains outdated links to intel/pcm for build instructions and non-root execution
  • doc/LATENCY-OPTIMIZED-MODE.md: Contains outdated links to intel/pcm for downloading and building instructions
  • doc/STARS.md: Contains an outdated star history chart URL referencing intel/pcm
🔗 Analysis chain

Verify consistency of repository URLs across documentation.

Let's check if there are any remaining references to the old repository that need to be updated.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining references to intel/pcm in documentation

echo "Checking for remaining intel/pcm references in documentation..."
rg -t md "intel/pcm" doc/

echo "Checking for inconsistent repository references..."
rg -t md "github\.com/[^/]+/pcm" doc/

Length of output: 2607

🧰 Tools
🪛 Markdownlint (0.35.0)

27-27: Column: 9
Hard tabs

(MD010, no-hard-tabs)

26-26: null
Bare URL used

(MD034, no-bare-urls)

27-27: null
Bare URL used

(MD034, no-bare-urls)


The scripts require the pcm-tpmi utility. There are several methods to obtain this utility:
- **Download or install precompiled PCM binaries:** Please refer to the following link: [Downloading Pre-Compiled PCM Tools](https://github.com/intel/pcm?tab=readme-ov-file#downloading-pre-compiled-pcm-tools)
Expand Down
2 changes: 1 addition & 1 deletion doc/LINUX_HOWTO.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ Running tests:

* build PCM
* as root run "sh test/test.sh"
- Automated CI test workflow: https://github.com/intel/pcm/blob/03ad6b0228c9e8a8eb022708b53a61875b9447bc/.github/workflows/ci-test.yml#L40
- Automated CI test workflow: https://github.com/khulnasoft/pcm/blob/03ad6b0228c9e8a8eb022708b53a61875b9447bc/.github/workflows/ci-test.yml#L40
2 changes: 1 addition & 1 deletion doc/PCM-EXPORTER.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ The default output of pcm-sensor-server endpoint in a browser:

The PCM exporter can be used together with Grafana to obtain these Intel processor metrics (see [how-to](../scripts/grafana/README.md)):

![pcm grafana output](https://raw.githubusercontent.com/wiki/intel/pcm/pcm-dashboard-full.png)
![pcm grafana output](https://raw.githubusercontent.com/wiki/khulnasoft/pcm/pcm-dashboard-full.png)
2 changes: 1 addition & 1 deletion doc/PCM_ACCEL_README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ Please refer to the spec or code to learn more about the event mapping if you wa

- IAA/DSA: https://software.intel.com/en-us/download/intel-data-streaming-accelerator-preliminary-architecture-specification

- QAT: please refer to the [mapping table in source code](https://github.com/intel/pcm/blob/f20013f7563714cf592d7a59f169c1ddee3cf8ba/src/cpucounters.cpp#L915)
- QAT: please refer to the [mapping table in source code](https://github.com/khulnasoft/pcm/blob/f20013f7563714cf592d7a59f169c1ddee3cf8ba/src/cpucounters.cpp#L915)


Here is the content of the event cfg file(opCode-6-143-accel.txt as example)
Expand Down
2 changes: 1 addition & 1 deletion pcm-kubernetes.yaml.experimental
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
spec:
automountServiceAccountToken: false
containers:
- image: ghcr.io/intel/pcm:latest
- image: ghcr.io/khulnasoft/pcm:latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider pinning the container image to a specific version

Using the latest tag in production environments can lead to non-deterministic deployments and complicate rollbacks. Consider using a specific version tag instead.

-      - image: ghcr.io/khulnasoft/pcm:latest
+      - image: ghcr.io/khulnasoft/pcm:v1.0.0  # Replace with actual version

Committable suggestion skipped: line range outside the PR's diff.

env:
- name: PCM_NO_MSR
value: "1"
Expand Down
2 changes: 1 addition & 1 deletion scripts/grafana/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ Installation of the grafana front-end (can be on any *host* system with connecti
5. You can also stop and delete the containers when needed: `sudo bash stop.sh`


![pcm grafana output](https://raw.githubusercontent.com/wiki/intel/pcm/pcm-dashboard-full.png)
![pcm grafana output](https://raw.githubusercontent.com/wiki/khulnasoft/pcm/pcm-dashboard-full.png)
4 changes: 2 additions & 2 deletions src/pcm-sensor-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ class PrometheusPrinter : Visitor
printCounter( "Invariant TSC", getInvariantTSC ( before, after ) );
printCounter( "SMI Count", getSMICount ( before, after ) );
#if 0
// disabling this metric for a moment due to https://github.com/intel/pcm/issues/789
// disabling this metric for a moment due to https://github.com/khulnasoft/pcm/issues/789
printCounter( "Core Frequency", getActiveAverageFrequency ( before, after ) );
#endif
//DBG( 2, "Invariant TSC before=", before.InvariantTSC, ", after=", after.InvariantTSC, ", difference=", after.InvariantTSC-before.InvariantTSC );
Expand Down Expand Up @@ -763,7 +763,7 @@ class PrometheusPrinter : Visitor
printCounter( "PP1 Joules Consumed", getConsumedJoules ( 1, before, after ) );
printCounter( "DRAM Joules Consumed", getDRAMConsumedJoules ( before, after ) );
#if 0
// disabling these metrics for a moment due to https://github.com/intel/pcm/issues/789
// disabling these metrics for a moment due to https://github.com/khulnasoft/pcm/issues/789
auto uncoreFrequencies = getUncoreFrequencies( before, after );
for (size_t i = 0; i < uncoreFrequencies.size(); ++i)
{
Expand Down