Fix: ls throws IOError on empty directories #1
Conversation
Null is a valid return value for empty directories.
src/System/HDFS.hs
Outdated
| @@ -191,12 +191,15 @@ ls :: FileSystem -> Path -> IO [FileInfo] | |||
| ls (FileSystem fs) p = | |||
| withCString p $ \path -> | |||
| alloca $ \numptr -> do | |||
| cinfo <- throwErrnoIfNull "ls" $ | |||
| cinfo <- --throwErrnoIfNull "ls" $ | |||
There was a problem hiding this comment.
Would you mind just removing the commented code?
|
Thanks. Are you actually using this, or planning to? Since CDH 5.x, there exists a much more lightweight and easier to maintain solution for interacting with HDFS. |
|
Well, I'm currently playing around with it. I've also seen the solution you mentioned, but unfortunately it doesn't support PUT (jacobstanley/hadoop-tools#15) - and so I believe the simple abstraction over hdfslib might be a better fit if I would like to store data in HDFS. |
Ok, wasn't aware of that. It doesn't actually seem to be an upstream restriction, though, there is a Go client which seems to support it. Anyways, if you end up using the code here, be aware that I've never used it for anything serious and would think that it would require some work to make it usable in a production setting. I don't really plan to release/maintain it, but would gladly help out if you'd be taking the lead. The license can also be made more liberal. |
Null is a valid return value for empty directories.
See also: avaranovich/libhdfs#1