Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible implementation for "Not enough space storage" message. #1050

Closed
wants to merge 2 commits into from

Conversation

franklinthai
Copy link

@franklinthai franklinthai commented Mar 8, 2024

Fixes #959

Added more error message output including target directory and space available.

Copy link
Member

@mgautierfr mgautierfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you PR.

However, your PR doesn't handle translation.
You have to extend at least https://github.com/kiwix/kiwix-desktop/blob/main/resources/i18n/en.json to update or add new strings (and potatially update https://github.com/kiwix/kiwix-desktop/blob/main/resources/i18n/qqq.json to give information to translators about the string to translate).

And then, insert the values in the string before displaying it (as a example, this is done this way here

auto text = gt("cancel-download-text");
text = text.replace("{{ZIM}}", QString::fromStdString(mp_library->getBookById(id).getTitle()));
)

@kelson42
Copy link
Collaborator

kelson42 commented Apr 6, 2024

@franklinthai Any feedback?

@franklinthai
Copy link
Author

I have not been able to fix this yet. I'll try to get on it in the next few days.

@franklinthai
Copy link
Author

Hello, sorry for being assigned this issue for so long and not being able to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give more information about the "Not enough space storage" message.
3 participants