Fix #967: Search Bar Key Board Short Cut Performs the same as Mouse Click #1061
Conversation
kelson42
force-pushed
the
Issue#967-fix-search-bar-shortcut
branch
from
d967894 to
bb5c340
Compare
|
@ShaopengLin Thank you very much for your PR, I finally have assigned a reviewer for it. |
| CREATE_ACTION_SHORTCUT(SearchArticleAction, gt("search-article"), QKeySequence(Qt::CTRL | Qt::Key_L)); | ||
| HIDE_ACTION(SearchArticleAction); | ||
| CREATE_ACTION_SHORTCUTS(SearchArticleAction, gt("search-article"), QList<QKeySequence>({QKeySequence(Qt::Key_F6), QKeySequence(Qt::CTRL | Qt::Key_L), QKeySequence(Qt::ALT | Qt::Key_D)})); |
There was a problem hiding this comment.
Did you unhide the SearchArticleAction intentionally?
| @@ -403,8 +403,7 @@ void KiwixApp::createActions() | |||
| HIDE_ACTION(SavePageAsAction); | |||
| */ | |||
|
|
|||
| CREATE_ACTION_SHORTCUT(SearchArticleAction, gt("search-article"), QKeySequence(Qt::CTRL | Qt::Key_L)); | |||
| HIDE_ACTION(SearchArticleAction); | |||
| CREATE_ACTION_SHORTCUTS(SearchArticleAction, gt("search-article"), QList<QKeySequence>({QKeySequence(Qt::Key_F6), QKeySequence(Qt::CTRL | Qt::Key_L), QKeySequence(Qt::ALT | Qt::Key_D)})); | |||
|
|
|||
| CREATE_ACTION_SHORTCUT(SearchLibraryAction, gt("search-in-library"), QKeySequence(Qt::CTRL | Qt::SHIFT | Qt::Key_R)); | |||
| HIDE_ACTION(SearchLibraryAction); | |||
There was a problem hiding this comment.
Question to @kelson42 and @mgautierfr: SearchLibraryAction doesn't seem to work in the current version of kiwix-desktop. Did it ever work, was support for it deliberately dropped or was that functionally accidentally broken?
There was a problem hiding this comment.
@veloman-yunkan I'm not able to answer at the code level. What is user visible impact?
There was a problem hiding this comment.
@kelson42 The question is not about the change. It is about the search-in-library action that is supposed to be activated via the CTRL+SHIFT+R keyboard shortcut.
There was a problem hiding this comment.
Probably never worked. Multi-zim search is implemented in libzim but I don't recall we have implemented it in kiwix-desktop.
There was a problem hiding this comment.
For me this ticket is not about the library... so I wonder why we talk about it! Honestly I have not clue what this PR should fixed because I don't understand the issue in a first place. So probably not going to merge it as long as the issue itself is not "cristal clear".
kelson42
force-pushed
the
Issue#967-fix-search-bar-shortcut
branch
2 times, most recently
from
cdec31a to
dd1b120
Compare
kelson42
force-pushed
the
Issue#967-fix-search-bar-shortcut
branch
from
dd1b120 to
3ad884e
Compare
Refactored shortcut to search bar and removed redundant code. Fix kiwix#967
kelson42
force-pushed
the
Issue#967-fix-search-bar-shortcut
branch
from
3ad884e to
366ab1d
Compare
Bug reason:
Our current focus in events performs actions based on event types, but we did not pass an event type into a user-defined focus event.
Changes:
Fix #967