Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented application language change behavior and setting #1069

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sgourdas
Copy link
Collaborator

@sgourdas sgourdas commented Mar 26, 2024

I have added logic to implement language change from the settings menu with a dropdown menu trying to close #478

@kelson42
Copy link
Collaborator

kelson42 commented Apr 8, 2024

@sgourdas Here again sorry for the lack of feedback, this is a bit more PR than usual :) Can you please rebase it on main and fix the conflicts?

@sgourdas sgourdas force-pushed the feature/language_changer branch from 818dfef to 4ddc47d Compare April 9, 2024 15:56
@kelson42 kelson42 force-pushed the feature/language_changer branch from ccb1323 to 6399342 Compare April 14, 2024 13:21
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR works "in principle" but suffers from many problems:

  • The user is not invited to restart the app after setting a new language in the settings
  • The languages in the select box are all in English. Either it should be in the language of the current UI OR each language should be written in its own language
  • Many language are just "C"
    image

@sgourdas
Copy link
Collaborator Author

I have refactored the logic to dynamically import language codes from the available files in the i18n folder. The following issues have been observed:

  • io.json and nb.json do not have a name field, necessary for getting the native name of the language. Regardless I have a check in place to skip files with this issue, but I think we might need to make sure that only substantially complete languages are in this directory, to be used.
  • A lot of languages are incomplete like yo.json or bcl.json where even the name field of the json file is incorrect and misleading. One check I have in place to mitigate these issues is if QLocale(code).language() returns C I skip this language.
  • Languages like Chinese are unable to be rendered with our font and I am not sure how to proceed with this.
    image
    Some examples are বাংলা" (bn.json), हिन्दी (hi.json), 英語 (ja.json), 한국어 (ko.json). If you want the complete list please ask me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to change the UI language / Application default language
2 participants