Explain what sample application is, in no-dns.md
#5676
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Welcome @ofey404! It looks like this is your first PR to knative/docs 🎉 |
knative-prow
bot
added
the
size/XS
|
/cc @dprotaso |
There was a problem hiding this comment.
I see your point. I think the first sentence here tries to say, you can deploy your own web-application with Knative to verify your setup or use the sample application.
How about if add a link to the sample application in the first sentence of that paragraph:
If you are using
curlto access the sample applications, or your own Knative app
ReToCode
requested review from
ReToCode
and removed request for
dprotaso and
nainaz
Good idea. It doesn't change the original doc and make things more concise. EDITED. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ofey404, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
This PR is a documentation enhancement. It adds the missing reference to the sample application.
Proposed Changes
The
helloworld-go applicationhere is a backward reference, as a newcomer, I have no idea where it is.So I added a
tipsection, linking to the first service page - https://knative.dev/docs/getting-started/first-service/