-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPDATED] the home page svg file #5721
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinfinity7 you will have to replace the existing home image for the flowchart for this change to work, rather than create a new one. If you look at the site preview for this PR (https://deploy-preview-5721--knative.netlify.app/docs/), it is still showing the old image.
@Cali0707 please review the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinfinity7 the file overrides/images/home-images/knative_flowchart_graphic.svg
is still here, even though it looks like you've deleted it's contents. Can you delete it fully?
Also, you have been adding a new file, when what this issue is asking you to do is to replace the existing file. Can you find the file that is currently being used in the homepage and replace it, rather than adding any new files and/or changing the src
of the img
tag?
@Cali0707 you might wanna lead me on this ! |
@vinfinity7 if you look here: https://github.com/knative/docs/tree/main/docs/images/home-images you will see that there already is a file with the old image. What you should do is replace that file with the new one, rather than creating a new file. Thanks to git, we will always be able to go back and find the old file if needed. |
|
Co-authored-by: Calum Murray <[email protected]>
@Cali0707 why is the Knative Verify Build test failing ? |
This is an unrelated issue to your changes, I wouldn't worry about it |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmejia02, vinfinity7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #5720
The Home page svg file has been changed to new one provided to me 👍