Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPDATED] twitter logo #5725

Merged
merged 10 commits into from
Oct 23, 2023
Merged

[UPDATED] twitter logo #5725

merged 10 commits into from
Oct 23, 2023

Conversation

vinfinity7
Copy link
Contributor

@vinfinity7 vinfinity7 commented Oct 19, 2023 •
edited
Loading

"Fixes #5724 "
Updated the logo and the supporting text

@knative-prow knative-prow bot requested review from nak3 and pmbanugo October 19, 2023 19:24
@netlify
Copy link

netlify bot commented Oct 19, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 36155b2
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65363acb0ad2ce0008b11ea8
😎 Deploy Preview https://deploy-preview-5725--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2023
@nak3
Copy link
Contributor

nak3 commented Oct 20, 2023

/cc @knative/steering-committee

@knative-prow knative-prow bot requested a review from a team October 20, 2023 02:56
@pmbanugo
Copy link
Member

I think there might be more places to update the logo. One place I can think of is at the footer.

Screenshot 2023-10-20 at 10 28 06

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2023
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2023
@vinfinity7

This comment was marked as spam.

Sign in to view
@nak3 nak3 removed their request for review October 22, 2023 11:59
@nak3
Copy link
Contributor

nak3 commented Oct 22, 2023

Is it possible to fix Knative Verify / Verify mkdocs strict (1.16.x, ubuntu-latest) (pull_request) - https://github.com/knative/docs/actions/runs/6590311651/job/17906662056?pr=5725 ?

@nak3
Copy link
Contributor

nak3 commented Oct 22, 2023

Fixing #5727

@pmbanugo
Copy link
Member

/lgtm

Hey @vinfinity7 I'd like to mention that consistently tagging people doesn't mean they'll review your PR. It rather becomes annoying in this case.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@pmbanugo pmbanugo removed their assignment Oct 23, 2023
@vinfinity7
Copy link
Contributor Author

/lgtm

Hey @vinfinity7 I'd like to mention that consistently tagging people doesn't mean they'll review your PR. It rather becomes annoying in this case.

Yes , it's just that I was being replied multiple times to tag people from sc , thats why I wanted to be heard ! would keep that In mind

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@lance
Copy link
Member

lance commented Oct 23, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@vinfinity7
Copy link
Contributor Author

/lgtm

consider merging sir 👍

@lance
Copy link
Member

lance commented Oct 23, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, vinfinity7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@knative-prow knative-prow bot merged commit 29e5a96 into knative:main Oct 23, 2023
16 checks passed
@vinfinity7 vinfinity7 deleted the twitter-x branch October 23, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbanugo pmbanugo Awaiting requested review from pmbanugo

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating the twitter logo to X
4 participants
@vinfinity7 @nak3 @pmbanugo @lance