-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nav.yml for navigating blog post about kubecon na 23 #5735
Conversation
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -86,6 +86,7 @@ nav: | |||
- steering/2020-01-annual-report-2019.md | |||
- steering/2019-12-updates.md | |||
- Events: | |||
- events/knative-at-kubecon-na-2023.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 2024? The links does not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see that change here: #5734
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
Update nav.yml for navigating blog post about kubecon na 23
e374832
to
39060a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nainaz, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "Knative Verify / Verify mkdocs strict" |
@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update nav.yml for navigating blog post about kubecon na 23
"Fixes #issue-number" or "Add description of the problem this PR solves"
Proposed Changes