Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nav.yml for navigating blog post about kubecon na 23 #5735

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

nainaz
Copy link
Contributor

@nainaz nainaz commented Oct 24, 2023

Update nav.yml for navigating blog post about kubecon na 23

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

@knative-prow knative-prow bot requested a review from nak3 October 24, 2023 16:50
@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for knative ready!

Name Link
🔨 Latest commit 39060a5
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6538a841aa73f90008af19f0
😎 Deploy Preview https://deploy-preview-5735--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot requested a review from ReToCode October 24, 2023 16:50
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2023
@@ -86,6 +86,7 @@ nav:
- steering/2020-01-annual-report-2019.md
- steering/2019-12-updates.md
- Events:
- events/knative-at-kubecon-na-2023.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 2024? The links does not work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see that change here: #5734

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Update nav.yml for navigating blog post about kubecon na 23
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nainaz, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Member

/override "Knative Verify / Verify mkdocs strict"

@knative-prow
Copy link

knative-prow bot commented Oct 25, 2023

@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Knative Verify / Verify mkdocs strict

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • Verify mkdocs strict (1.16.x, ubuntu-latest)
  • netlify/knative/deploy-preview
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Knative Verify / Verify mkdocs strict"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit ff76d17 into main Oct 25, 2023
16 of 17 checks passed
@dprotaso dprotaso deleted the nainaz-patch-3 branch July 30, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants