-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding initial doc for func subscribe #5754
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@lkingland here is my initial doc PR |
``` | ||
|
||
!!! note | ||
When invoking `func deploy` the CLI will create Knative Triggers for the function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move this note above the code blocks, line no. 7 of the .md
file. Otherwise looks OK to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've separated that now, and added a more dedicated section, with a smalll focus on the deployment.
Moving the note to far up seems a bit odd to me...
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
9711b37
to
d25f299
Compare
/approve @matzew @lkingland adding both labels & hold to merge on demand. :) |
!!! note | ||
When invoking `func deploy` the CLI will create Knative Triggers for the function. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matzew have you intentionally removed the note box?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I have. please see the rendered page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean and to the point 👍🏻 ❤️ Thanks for the docs!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, lkingland, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Proposed Changes
func subscribe