Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use create instead of apply #5785

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Dec 4, 2023

/assign @skonto

/cherry-pick release-1.12

Copy link

knative-prow bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from pierDipi and skonto December 4, 2023 12:50
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 38588c3
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/656dcb091244d400088bde42
😎 Deploy Preview https://deploy-preview-5785--knative.netlify.app/docs/install/upgrade/upgrade-installation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2023
@skonto
Copy link
Contributor

skonto commented Dec 7, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@skonto skonto added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@knative-prow knative-prow bot merged commit ae88a5e into knative:main Dec 7, 2023
19 checks passed
@ReToCode
Copy link
Member Author

ReToCode commented Dec 7, 2023

/cherry-pick release-1.12

@skonto skonto removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #5793

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skonto
Copy link
Contributor

skonto commented Dec 7, 2023

I verified the PR:

kubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.11.2/serving-post-install-jobs.yaml
error: from storage-version-migration-serving-: cannot use generate name with apply

create works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants