Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Security Audit to blog nav #5788

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

evankanderson
Copy link
Member

@evankanderson evankanderson commented Dec 5, 2023

Follow-up to #5775

Proposed Changes

  • Add security audit to nav under "events", following putting the fuzzing audit under the same.
  • Add security audit to "Featured Posts"

@knative-prow knative-prow bot requested a review from csantanapr December 5, 2023 14:22
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@knative-prow knative-prow bot requested a review from nak3 December 5, 2023 14:22
Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8195730
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/656f38bae37d310008034598
😎 Deploy Preview https://deploy-preview-5788--knative.netlify.app/blog
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2023
@evankanderson
Copy link
Member Author

/assign @AdamKorcz @davidhadas

I forgot to check this earlier, and I somehow thought the blog nav was auto-updated.

Copy link

knative-prow bot commented Dec 5, 2023

@evankanderson: GitHub didn't allow me to assign the following users: AdamKorcz.

Note that only knative members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @AdamKorcz @davidhadas

I forgot to check this earlier, and I somehow thought the blog nav was auto-updated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@AdamKorcz AdamKorcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

knative-prow bot commented Dec 5, 2023

@AdamKorcz: changing LGTM is restricted to collaborators

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

knative-prow bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdamKorcz, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidhadas
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
@knative-prow knative-prow bot merged commit b25d760 into knative:main Dec 5, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants