Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ML example #5983

Merged
merged 4 commits into from
Dec 29, 2024
Merged

fix ML example #5983

merged 4 commits into from
Dec 29, 2024

Conversation

mattn
Copy link
Contributor

@mattn mattn commented May 21, 2024

Fix machinelearning-python-bentoml to work in latest Python and bentoml.

Copy link

knative-prow bot commented May 21, 2024

Welcome @mattn! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 21, 2024
@knative-prow knative-prow bot requested review from skonto and snneji May 21, 2024 14:51
Copy link

netlify bot commented May 21, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5d04482
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/664cc7aaffd2260007b7a2c2
😎 Deploy Preview https://deploy-preview-5983--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aliok
Copy link
Member

aliok commented May 29, 2024

cc @knative/serving-approvers

Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2024
@github-actions github-actions bot closed this Sep 28, 2024
@mattn
Copy link
Contributor Author

mattn commented Sep 28, 2024

/reopen

@knative-prow knative-prow bot reopened this Sep 28, 2024
Copy link

knative-prow bot commented Sep 28, 2024

@mattn: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 29, 2024
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2024
Copy link

knative-prow bot commented Dec 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mattn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2024
@knative-prow knative-prow bot merged commit b8ff86b into knative:main Dec 29, 2024
6 checks passed
@dprotaso
Copy link
Member

thanks for the fix!

/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6184

In response to this:

thanks for the fix!

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

/cherry-pick release-1.15

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6187

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants