Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added documentation for keda scaling of Kafka dispatcher components #6061

Merged
merged 1 commit into from
Jul 24, 2024
Merged

feat: added documentation for keda scaling of Kafka dispatcher components #6061

merged 1 commit into from
Jul 24, 2024

Conversation

Cali0707
Copy link
Member

We now have KEDA scaling of all Knative Kafka dispatcher components. This PR adds:

  • docs mentioning that this exists
  • docs explaining how to use this

@knative-prow knative-prow bot requested review from Leo6Leo and pierDipi July 18, 2024 19:37
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2024
@Cali0707
Copy link
Member Author

/cc @Leo6Leo @pierDipi @matzew

@knative-prow knative-prow bot requested a review from matzew July 18, 2024 19:37
@netlify Netlify
Copy link

netlify bot commented Jul 18, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c98d19d
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66996f7196b66b0008572a59
😎 Deploy Preview https://deploy-preview-6061--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Cali0707 Cali0707 force-pushed the document-keda-scaling branch from 9d69373 to c98d19d Compare July 18, 2024 19:39
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2024
pierDipi
pierDipi approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit c98a44e into knative:main Jul 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@matzew matzew Awaiting requested review from matzew

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cali0707 @pierDipi