Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.15] feat: documented new trigger filters are GA (#6060) #6093

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Aug 9, 2024

This is a backport of #6060 so that we can document trigger filters being GA in the release 1.15 docs

* feat: documented new trigger filters are GA

Signed-off-by: Calum Murray <[email protected]>

* fix: formatting

Signed-off-by: Calum Murray <[email protected]>

* cleanup: remove trigger filters feature file

Signed-off-by: Calum Murray <[email protected]>

* fix: redirect should work for experimental-features/new-trigger-filters

Signed-off-by: Calum Murray <[email protected]>

---------

Signed-off-by: Calum Murray <[email protected]>
@knative-prow knative-prow bot requested review from pierDipi and ReToCode August 9, 2024 14:24
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Aug 9, 2024

/cc @pierDipi @creydr @Leo6Leo

@knative-prow knative-prow bot requested review from creydr and Leo6Leo August 9, 2024 14:24
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
Copy link

knative-prow bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8a73b4e into knative:release-1.15 Aug 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants