Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sources table rendering #6140

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

prushh
Copy link
Contributor

@prushh prushh commented Oct 16, 2024

Fixes #6139

Proposed Changes

  • add missing table delimiters (pipes)
  • update RedisSource url with knative-extensions/eventing-redis repository url
  • update RediSource channel from Alpha to Beta (Ref)

@knative-prow knative-prow bot requested review from csantanapr and pierDipi October 16, 2024 14:37
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2024
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8024a23
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/67168d2b3445cf000829d74c
😎 Deploy Preview https://deploy-preview-6140--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prushh
Copy link
Contributor Author

prushh commented Oct 16, 2024

Should I bump the RedisSource status to "Beta"?
Ref: https://github.com/knative-extensions/eventing-redis?tab=readme-ov-file#redis-components-for-knative

Edit: Also let me know if I can fix the unit tests in this PR, I think it is only necessary to change the version of express in the Recreating the sample code section of this README.md

@Cali0707
Copy link
Member

Should I bump the RedisSource status to "Beta"? Ref: https://github.com/knative-extensions/eventing-redis?tab=readme-ov-file#redis-components-for-knative

Yes, it looks like the components are beta, so correcting that would be really helpful!

Edit: Also let me know if I can fix the unit tests in this PR, I think it is only necessary to change the version of express in the Recreating the sample code section of this README.md

I think it would be fine to fix it in either this PR or a new one

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @prushh !

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
Copy link

knative-prow bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, prushh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@knative-prow knative-prow bot merged commit aeb82f0 into knative:main Oct 21, 2024
19 checks passed
@prushh prushh deleted the fix-sources-on-table branch October 21, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knative Sources table is not rendered properly in browser
2 participants