-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sources table rendering #6140
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Should I bump the RedisSource status to "Beta"? Edit: Also let me know if I can fix the unit tests in this PR, I think it is only necessary to change the version of express in the Recreating the sample code section of this README.md |
Yes, it looks like the components are beta, so correcting that would be really helpful!
I think it would be fine to fix it in either this PR or a new one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @prushh !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, prushh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #6139
Proposed Changes
knative-extensions/eventing-redis
repository url