Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove next/previous text from blog footer #6142

Merged
merged 3 commits into from
Oct 24, 2024
Merged

fix: remove next/previous text from blog footer #6142

merged 3 commits into from
Oct 24, 2024

Conversation

prushh
Copy link
Contributor

@prushh prushh commented Oct 21, 2024 •
edited
Loading

Fixes #6124

Proposed Changes

  • remove next/previous text in blog footer, based on config.site_url variable

@knative-prow knative-prow bot requested review from Leo6Leo and ReToCode October 21, 2024 16:49
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 21, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dcb548a
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/671757cc2e37270008cddf5e
😎 Deploy Preview https://deploy-preview-6142--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prushh prushh marked this pull request as draft October 21, 2024 17:03
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024
@prushh prushh marked this pull request as ready for review October 22, 2024 07:46
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@knative-prow knative-prow bot requested a review from mmejia02 October 22, 2024 07:46
Cali0707
Cali0707 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prushh !
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, prushh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@knative-prow knative-prow bot merged commit ad6c51b into knative:main Oct 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@ReToCode ReToCode Awaiting requested review from ReToCode

@mmejia02 mmejia02 Awaiting requested review from mmejia02

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove next/previous text from blog footer
2 participants
@prushh @Cali0707