Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #6179

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Conversation

valtterikantanen
Copy link
Contributor

This PR fixes two broken links in the documentation that were producing 404 errors.

@knative-prow knative-prow bot requested review from csantanapr and nainaz December 22, 2024 13:07
Copy link

linux-foundation-easycla bot commented Dec 22, 2024

CLA Signed

  • ✅login: valtterikantanen / (bfa55b6)

The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Dec 22, 2024

Welcome @valtterikantanen! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 22, 2024
Copy link

netlify bot commented Dec 22, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bfa55b6
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/67680f047b8d84000803d73c
😎 Deploy Preview https://deploy-preview-6179--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@valtterikantanen
Copy link
Contributor Author

/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

@valtterikantanen: only knative org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

/lgtm
/approve
/cherry-pick release-1.16
/cherry-pick release-1.15

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.15, release-1.16 in new PRs and assign them to you.

In response to this:

/lgtm
/approve
/cherry-pick release-1.16
/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2024
Copy link

knative-prow bot commented Dec 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, valtterikantanen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2024
@knative-prow knative-prow bot merged commit 818e462 into knative:main Dec 29, 2024
6 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6182

In response to this:

/lgtm
/approve
/cherry-pick release-1.16
/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6183

In response to this:

/lgtm
/approve
/cherry-pick release-1.16
/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants