Cleanup orphaned func, new image-name calculation

[gauron99]

Changes

• 🧹 Delete old image on ns change
• Add new image field in deploy section - recalculate image name unless it was explicitly given

Whats new

1. In case user explicitly specifies --namespace in a subsequent func deploy, the "old" func deployed will be deleted after the new one is deployed successfully.
2. New field added as .Build.Image which will serve as the new .Image currently with few changes. -> this serves as further following the idea that Func.yaml shouldnt be possibly manipulated with at all (.Build fields shouldnt be manipulated with now same as .Deploy).

• Instead the .Image now is empty UNLESS its specified by user using --image flag in which case it will be used in all subsequent builds because by specifying this flag user says "I know what Im doing" and no image name calculation will be performed.

3. new field in runtime metadata directory .func/ called built-image now serves as runtime last built image name. Once pushed this also contains a sha (This is temporary, either will be fixed in this PR or separately. -- the issue is that sha is fetched from Push action instead of Build, where it should be possible to get it)

---

4. Namespace structure updated: Now f.Namespace describes namespace TO BE deployed in (user defined) and f.Deploy.Namespace describes namespace Function WAS deployed in; in other words, one is the desired namespace and the other is the current status, where the Function is already deployed.

additional

new error definitions
test updates and fixups to fit new structures

TODO

• fix new errors in tests

/kind cleanup

Fixes #1953

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Attention: Patch coverage is 68.78453% with 113 lines in your changes are missing coverage. Please review.

Project coverage is 63.21%. Comparing base (b97d841) to head (483bd36).
Report is 7 commits behind head on main.

❗ Current head 483bd36 differs from pull request most recent head 5cb7e1a. Consider uploading reports for the commit 5cb7e1a to get more accurate results

Files	Patch %	Lines
pkg/functions/client.go	56.57%	23 Missing and 10 partials ⚠️
pkg/pipelines/tekton/pipelines_provider.go	50.94%	24 Missing and 2 partials ⚠️
pkg/functions/function.go	74.57%	10 Missing and 5 partials ⚠️
cmd/deploy.go	81.81%	8 Missing and 4 partials ⚠️
pkg/knative/remover.go	40.00%	5 Missing and 1 partial ⚠️
pkg/k8s/persistent_volumes.go	0.00%	4 Missing and 1 partial ⚠️
pkg/pipelines/tekton/client.go	28.57%	4 Missing and 1 partial ⚠️
pkg/pipelines/tekton/pac/client.go	44.44%	4 Missing and 1 partial ⚠️
cmd/build.go	0.00%	1 Missing ⚠️
pkg/docker/pusher.go	80.00%	0 Missing and 1 partial ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1962      +/-   ##
==========================================
- Coverage   64.21%   63.21%   -1.01%     
==========================================
  Files         108      108              
  Lines       13918    14026     +108     
==========================================
- Hits         8937     8866      -71     
- Misses       4108     4282     +174     
- Partials      873      878       +5     

Flag	Coverage Δ
e2e-test	37.36% <38.95%> (-0.02%)	⬇️
e2e-test-oncluster	30.66% <43.09%> (+0.16%)	⬆️
e2e-test-oncluster-runtime	26.85% <25.69%> (?)
e2e-test-runtime-go	25.66% <35.08%> (?)
e2e-test-runtime-node	26.66% <35.63%> (?)
e2e-test-runtime-python	26.66% <35.63%> (?)
e2e-test-runtime-quarkus	26.78% <35.63%> (?)
e2e-test-runtime-rust	25.68% <35.08%> (?)
e2e-test-runtime-springboot	25.81% <35.08%> (?)
e2e-test-runtime-typescript	26.78% <35.63%> (?)
integration-tests	?
unit-tests-macos-latest	48.93% <52.69%> (+0.08%)	⬆️
unit-tests-ubuntu-latest	49.67% <52.69%> (+0.08%)	⬆️
unit-tests-windows-latest	48.98% <52.97%> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lkingland]

Looking great, and all the pertinent tests are passing! (a couple of timeouts notwithstanding).

I requested a couple small changes moving logic around, but generally looks GTG to me! 🥳

[lkingland]

🎉

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gauron99,lkingland]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment