Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run "on cluster RT" tests in parallel #1991

Closed
wants to merge 1 commit into from

Conversation

matejvasek
Copy link
Contributor

Changes

  • Run on cluster RT tests in parallel.

@knative-prow
Copy link

knative-prow bot commented Sep 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7c9695) 59.10% compared to head (4672d39) 62.74%.
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1991      +/-   ##
==========================================
+ Coverage   59.10%   62.74%   +3.64%     
==========================================
  Files         106      106              
  Lines       13693    13693              
==========================================
+ Hits         8093     8592     +499     
+ Misses       4783     4232     -551     
- Partials      817      869      +52     
Flag Coverage Δ
e2e-test 36.46% <ø> (?)
e2e-test-oncluster 30.42% <ø> (-0.09%) ⬇️
e2e-test-oncluster-runtime 26.79% <ø> (?)
e2e-test-runtime-go 25.50% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-python 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-rust 25.59% <ø> (?)
e2e-test-runtime-springboot 25.73% <ø> (?)
e2e-test-runtime-typescript 26.71% <ø> (?)
integration-tests 51.43% <ø> (+2.11%) ⬆️
unit-tests-macos-latest 48.21% <ø> (ø)
unit-tests-ubuntu-latest 48.98% <ø> (-0.03%) ⬇️
unit-tests-windows-latest 48.23% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrangelramos
Copy link
Contributor

jrangelramos commented Sep 21, 2023

Hmm.. It took 34m to run in parallel.
On my previous PR it took 33m (not in paralell).
Maybe GH is just busy and it shall run faster some other PR or other moment..

The only caveat i the fact that s it mixes test log output which may turn a bit difficult to troubleshoot whenever something fails.. but I'm ok with that as long as it speed up tests.

@matejvasek
Copy link
Contributor Author

matejvasek commented Sep 22, 2023

@jrangelramos if tests use t.Log(), not raw output, then output is not really mixed, well maybe a little but in a way that can be demuxed. For instance if you run test in IDE it will split it for you.

This improves speed at least when testing locally. On GH not so much. For me it cut down 4 mins, but the variance is to high to tell.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2023
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2024
@github-actions github-actions bot closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants