Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: parallelize cluster allocate script #1992

Merged
merged 1 commit into from
Sep 27, 2023
Merged

chore: parallelize cluster allocate script #1992

merged 1 commit into from
Sep 27, 2023

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Sep 21, 2023 •
edited
Loading

Changes

Parallelised cluster allocate script.

@knative-prow
Copy link

knative-prow bot commented Sep 21, 2023

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow
Copy link

knative-prow bot commented Sep 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e7c9695) 59.10% compared to head (7f6652b) 62.74%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1992      +/-   ##
==========================================
+ Coverage   59.10%   62.74%   +3.64%     
==========================================
  Files         106      106              
  Lines       13693    13693              
==========================================
+ Hits         8093     8592     +499     
+ Misses       4783     4232     -551     
- Partials      817      869      +52
Flag Coverage Δ
e2e-test 36.46% <ø> (?)
e2e-test-oncluster 30.53% <ø> (+0.02%) ⬆️
e2e-test-oncluster-runtime 27.03% <ø> (?)
e2e-test-runtime-go 25.59% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-python 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-rust 25.59% <ø> (?)
e2e-test-runtime-springboot 25.73% <ø> (?)
e2e-test-runtime-typescript 26.71% <ø> (?)
integration-tests 51.38% <ø> (+2.05%) ⬆️
unit-tests-macos-latest 48.21% <ø> (ø)
unit-tests-ubuntu-latest 49.00% <ø> (ø)
unit-tests-windows-latest 48.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2023
@matejvasek matejvasek changed the title [TESTING ONLY] chore: parallelize cluster allocate script chore: parallelize cluster allocate script Sep 21, 2023
@matejvasek
Copy link
Contributor Author

matejvasek commented Sep 21, 2023 •
edited
Loading

@jrangelramos this makes cluster setup 2-3x faster.

@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2023
@matejvasek matejvasek marked this pull request as ready for review September 27, 2023 11:52
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos

@matejvasek matejvasek requested review from gauron99 and lkingland and removed request for rhuss September 27, 2023 11:52
@gauron99
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot merged commit 5ffdf75 into knative:main Sep 27, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@gauron99 gauron99 Awaiting requested review from gauron99

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@jrangelramos jrangelramos

@gauron99 gauron99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @jrangelramos @gauron99