Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update community files #1995

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

Produced by: knative-extensions/knobots/actions/update-community

Details:


@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a7c1558) 61.76% compared to head (415fecd) 60.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1995      +/-   ##
==========================================
- Coverage   61.76%   60.00%   -1.77%     
==========================================
  Files         106      106              
  Lines       13693    13693              
==========================================
- Hits         8458     8217     -241     
- Misses       4390     4633     +243     
+ Partials      845      843       -2     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster 30.42% <ø> (-0.11%) ⬇️
e2e-test-runtime-go 25.54% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-python 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-rust 25.59% <ø> (?)
e2e-test-runtime-springboot 25.73% <ø> (?)
e2e-test-runtime-typescript 26.71% <ø> (?)
integration-tests 51.41% <ø> (+2.08%) ⬆️
unit-tests-macos-latest 48.19% <ø> (-0.03%) ⬇️
unit-tests-ubuntu-latest 49.00% <ø> (?)
unit-tests-windows-latest 48.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707
Copy link
Member

/verify-owners

@knative-prow knative-prow bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 22, 2023
@knative-automation knative-automation force-pushed the auto-updates/update-community-main branch from e1e7684 to df14e2b Compare September 26, 2023 01:28
@Cali0707
Copy link
Member

/test

@knative-prow
Copy link

knative-prow bot commented Sep 26, 2023

@Cali0707: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test unit-tests

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Cali0707
Copy link
Member

/test all

@knative-automation knative-automation force-pushed the auto-updates/update-community-main branch from df14e2b to aed2062 Compare September 27, 2023 13:08
@skonto
Copy link

skonto commented Oct 2, 2023

@Cali0707 hi gentle ping. I am trying to verify step 1 here: knative/release#247 for release-1.12.

@skonto
Copy link

skonto commented Oct 2, 2023

/test all

@Cali0707
Copy link
Member

Cali0707 commented Oct 2, 2023

@skonto I think any invalid owner files should be fixed now!

@skonto
Copy link

skonto commented Oct 2, 2023

Yeah btw PRs on other repo were merged with /verify-owners. This PR is the last pending. @Cali0707 could you stamp it?
The run here does not pass: https://github.com/knative/release/actions/runs/6379955595, we need this in.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2023
@skonto
Copy link

skonto commented Oct 2, 2023

/approve

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2023
@knative-automation knative-automation force-pushed the auto-updates/update-community-main branch from aed2062 to 4f94dc5 Compare October 5, 2023 01:29
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@skonto
Copy link

skonto commented Oct 6, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2023
Signed-off-by: Knative Automation <[email protected]>
@knative-automation knative-automation force-pushed the auto-updates/update-community-main branch from 4f94dc5 to 415fecd Compare October 6, 2023 13:08
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2023
@skonto
Copy link

skonto commented Oct 6, 2023

@Cali0707 could you manually merge this one so we can move on? We will shortly have another PR with community files updates for 1.12, so we need to speed up this a bit.

@Cali0707
Copy link
Member

Cali0707 commented Oct 6, 2023

@skonto I don't have permissions to manually merge this

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, knative-automation, matejvasek, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor

/override "On Cluster RT Test (1.20.2, ubuntu-latest, s2i)"

@knative-prow
Copy link

knative-prow bot commented Oct 6, 2023

@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators.

In response to this:

/override "On Cluster RT Test (1.20.2, ubuntu-latest, s2i)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance
Copy link
Member

lance commented Oct 6, 2023

/override "On Cluster RT Test (1.20.2, ubuntu-latest, s2i)"

@knative-prow
Copy link

knative-prow bot commented Oct 6, 2023

@lance: Overrode contexts on behalf of lance: On Cluster RT Test (1.20.2, ubuntu-latest, s2i)

In response to this:

/override "On Cluster RT Test (1.20.2, ubuntu-latest, s2i)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance
Copy link
Member

lance commented Oct 6, 2023

/override "On Cluster RT Test (1.20.2, ubuntu-latest, pack)"

@knative-prow
Copy link

knative-prow bot commented Oct 6, 2023

@lance: Overrode contexts on behalf of lance: On Cluster RT Test (1.20.2, ubuntu-latest, pack)

In response to this:

/override "On Cluster RT Test (1.20.2, ubuntu-latest, pack)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit f832e85 into knative:main Oct 6, 2023
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants