Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH tests #2003

Merged
merged 1 commit into from
Oct 23, 2023
Merged

SSH tests #2003

merged 1 commit into from
Oct 23, 2023

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Oct 2, 2023

Changes

  • tests for SSH connections

@knative-prow
Copy link

knative-prow bot commented Oct 2, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow
Copy link

knative-prow bot commented Oct 2, 2023

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 2, 2023
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00591fd) 60.65% compared to head (ca7d0ea) 61.81%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
+ Coverage   60.65%   61.81%   +1.16%     
==========================================
  Files         106      106              
  Lines       13693    13693              
==========================================
+ Hits         8306     8465     +159     
+ Misses       4568     4372     -196     
- Partials      819      856      +37     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster 30.44% <ø> (?)
e2e-test-oncluster-runtime 26.96% <ø> (?)
e2e-test-runtime-go 25.59% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
integration-tests 51.90% <ø> (+2.54%) ⬆️
unit-tests-macos-latest 48.78% <ø> (+0.59%) ⬆️
unit-tests-ubuntu-latest 49.54% <ø> (+0.53%) ⬆️
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek matejvasek requested a review from lkingland October 2, 2023 23:15
@matejvasek matejvasek marked this pull request as ready for review October 2, 2023 23:15
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2023
@knative-prow knative-prow bot requested a review from nainaz October 2, 2023 23:15
@matejvasek
Copy link
Contributor Author

The unit-tests_func_main test is failing because it apparently runs under root.

@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99 @jrangelramos

1 similar comment
@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99 @jrangelramos

@matejvasek
Copy link
Contributor Author

@lance please override "On Cluster RT Test (1.20.2, ubuntu-latest, pack)" and "On Cluster RT Test (1.20.2, ubuntu-latest, s2i)"

@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99 @jrangelramos

@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99 @jrangelramos

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d65b812 into knative:main Oct 23, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants