Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: use local storage class for PVC #2075

Closed
wants to merge 1 commit into from

Conversation

matejvasek
Copy link
Contributor

Changes

/kind

Fixes #

Release Note


Docs


Copy link

knative-prow bot commented Nov 8, 2023

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

knative-prow bot commented Nov 8, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2023
Copy link

knative-prow bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2023
@matejvasek matejvasek force-pushed the test-local-storage-class branch from 64ed30d to 5e8dd89 Compare November 8, 2023 14:31
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7af58b5) 63.50% compared to head (64ed30d) 49.50%.

❗ Current head 64ed30d differs from pull request most recent head 5e8dd89. Consider uploading reports for the commit 5e8dd89 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2075       +/-   ##
===========================================
- Coverage   63.50%   49.50%   -14.01%     
===========================================
  Files         108      100        -8     
  Lines       13865    13644      -221     
===========================================
- Hits         8805     6754     -2051     
- Misses       4191     6235     +2044     
+ Partials      869      655      -214     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster ?
integration-tests ?
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/k8s/persistent_volumes.go 0.00% <0.00%> (-71.80%) ⬇️

... and 62 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek matejvasek closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant