Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SECURITY.md consistent #2089

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

evankanderson
Copy link
Member

We're missing these across a lot of Knative repos, this is copied/improved from the 3 that existed.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2023
@davidhadas
Copy link
Contributor

/retest

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f0b90d) 63.87% compared to head (c1c9116) 64.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2089      +/-   ##
==========================================
+ Coverage   63.87%   64.83%   +0.96%     
==========================================
  Files         108      108              
  Lines       13865    13865              
==========================================
+ Hits         8856     8990     +134     
+ Misses       4140     3982     -158     
- Partials      869      893      +24     
Flag Coverage Δ
e2e-test 36.67% <ø> (ø)
e2e-test-oncluster 30.49% <ø> (-0.06%) ⬇️
e2e-test-oncluster-runtime 26.89% <ø> (?)
e2e-test-runtime-python 26.55% <ø> (?)
e2e-test-runtime-quarkus 26.68% <ø> (?)
e2e-test-runtime-rust 25.57% <ø> (?)
e2e-test-runtime-springboot 25.71% <ø> (?)
e2e-test-runtime-typescript 26.68% <ø> (?)
integration-tests 51.79% <ø> (+2.00%) ⬆️
unit-tests-macos-latest 48.75% <ø> (ø)
unit-tests-ubuntu-latest ?
unit-tests-windows-latest 48.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidhadas
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
Copy link

knative-prow bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@knative-prow knative-prow bot merged commit f8a4284 into knative:main Nov 20, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants