Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include Quarkus BP in our builders #2106

Merged
merged 8 commits into from
Dec 13, 2023

Conversation

matejvasek
Copy link
Contributor

No description provided.

@matejvasek matejvasek requested a review from lkingland December 12, 2023 21:33
Copy link

knative-prow bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from nainaz and navidshaikh December 12, 2023 21:33
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2023
@matejvasek matejvasek requested review from gauron99 and jrangelramos and removed request for navidshaikh and nainaz December 12, 2023 21:34
@matejvasek
Copy link
Contributor Author

PTAL @lkingland @jrangelramos @gauron99

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76fde17) 62.78% compared to head (b552bf0) 61.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2106      +/-   ##
==========================================
- Coverage   62.78%   61.84%   -0.94%     
==========================================
  Files         108      108              
  Lines       13868    13868              
==========================================
- Hits         8707     8577     -130     
- Misses       4318     4426     +108     
- Partials      843      865      +22     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster 30.54% <ø> (?)
e2e-test-oncluster-runtime 26.82% <ø> (?)
e2e-test-runtime-go 25.57% <ø> (?)
e2e-test-runtime-node 26.56% <ø> (?)
e2e-test-runtime-python 26.56% <ø> (?)
e2e-test-runtime-quarkus 26.68% <ø> (?)
e2e-test-runtime-rust 25.57% <ø> (?)
e2e-test-runtime-springboot 25.70% <ø> (?)
e2e-test-runtime-typescript 26.68% <ø> (?)
integration-tests 51.81% <ø> (+2.02%) ⬆️
unit-tests-macos-latest 48.76% <ø> (ø)
unit-tests-ubuntu-latest 49.49% <ø> (ø)
unit-tests-windows-latest 48.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hack/update-builder.go Fixed Show fixed Hide fixed
hack/update-builder.go Fixed Show fixed Hide fixed
hack/update-builder.go Fixed Show fixed Hide fixed
hack/update-builder.go Fixed Show fixed Hide fixed
@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2023
@knative-prow knative-prow bot merged commit b9c11c3 into knative:main Dec 13, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants