Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GitLab test #2112

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix: GitLab test #2112

merged 2 commits into from
Jan 10, 2024

Conversation

matejvasek
Copy link
Contributor

No description provided.

Update to URL used in newer versions of GitLab.

Signed-off-by: Matej Vasek <[email protected]>
@knative-prow knative-prow bot requested review from dsimansk and rhuss January 10, 2024 14:17
Copy link

knative-prow bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2024
@matejvasek matejvasek requested review from jrangelramos, gauron99 and lkingland and removed request for rhuss and dsimansk January 10, 2024 14:17
@jrangelramos
Copy link
Contributor

/lgtm
.. as long as Gitlab test pass

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4daa885) 63.88% compared to head (3a7a917) 65.16%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2112      +/-   ##
==========================================
+ Coverage   63.88%   65.16%   +1.27%     
==========================================
  Files         108      108              
  Lines       13868    13870       +2     
==========================================
+ Hits         8860     9038     +178     
+ Misses       4139     3940     -199     
- Partials      869      892      +23     
Flag Coverage Δ
e2e-test 37.30% <ø> (+0.64%) ⬆️
e2e-test-oncluster 30.58% <ø> (+0.03%) ⬆️
e2e-test-oncluster-runtime 26.59% <ø> (?)
e2e-test-runtime-go 25.55% <ø> (?)
e2e-test-runtime-node 26.57% <ø> (?)
e2e-test-runtime-python 26.57% <ø> (?)
e2e-test-runtime-springboot 25.71% <ø> (?)
e2e-test-runtime-typescript 26.69% <ø> (?)
integration-tests 51.81% <ø> (+2.00%) ⬆️
unit-tests-macos-latest 48.77% <ø> (+0.02%) ⬆️
unit-tests-ubuntu-latest 49.52% <ø> (+<0.01%) ⬆️
unit-tests-windows-latest 48.79% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@knative-prow knative-prow bot merged commit 152d009 into knative:main Jan 10, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants