Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update func subscribe doc #2113

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

jrangelramos
Copy link
Contributor

Changes

  • 🧹 Update func subscribe DOC

@jrangelramos jrangelramos requested a review from matzew January 10, 2024 16:41
@knative-prow knative-prow bot requested review from dsimansk and gauron99 January 10, 2024 16:41
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2024
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
Copy link

knative-prow bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc0121f) 58.83% compared to head (4c6d572) 63.09%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
+ Coverage   58.83%   63.09%   +4.25%     
==========================================
  Files         101      108       +7     
  Lines       13649    13870     +221     
==========================================
+ Hits         8031     8751     +720     
+ Misses       4812     4256     -556     
- Partials      806      863      +57     
Flag Coverage Δ
e2e-test 37.30% <ø> (?)
e2e-test-oncluster 30.55% <ø> (?)
e2e-test-oncluster-runtime 26.83% <ø> (?)
e2e-test-runtime-go 25.55% <ø> (?)
e2e-test-runtime-node 26.57% <ø> (?)
e2e-test-runtime-python 26.57% <ø> (?)
e2e-test-runtime-quarkus 26.69% <ø> (?)
e2e-test-runtime-rust 25.58% <ø> (?)
e2e-test-runtime-springboot 25.71% <ø> (?)
e2e-test-runtime-typescript 26.69% <ø> (?)
integration-tests ?
unit-tests-macos-latest 48.77% <ø> (ø)
unit-tests-ubuntu-latest 49.50% <ø> (-0.03%) ⬇️
unit-tests-windows-latest 48.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrangelramos
Copy link
Contributor Author

Hello @ReToCode . Would you mind to override "Integration Test (ubuntu-latest)", pls ?

@ReToCode
Copy link
Member

/override "Integration Test (ubuntu-latest)"

Copy link

knative-prow bot commented Jan 11, 2024

@ReToCode: Overrode contexts on behalf of ReToCode: Integration Test (ubuntu-latest)

In response to this:

/override "Integration Test (ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 7f44e71 into knative:main Jan 11, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants