Remove toolchain directive

[dsimansk]

Changes

• Remove toolchain directive

We need to drop this at least temporarily until release is done, because one of our tools performing auto-update deps is not working with toolchain directive yet.

/cc @knative/knative-release-leads
/cc @matejvasek @lkingland

/kind

Fixes #

Release Note

NONE

[knative-prow]

@dsimansk: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

• Remove toolchain directive

We need to drop this at least temporarily until release is done, because one of our tools performing auto-update deps is not working with toolchain directive yet.

/cc @knative/knative-release-leads
/cc @matejvasek @lkingland

/kind

Fixes #

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[creydr]

/lgtm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f3a048) 64.19% compared to head (1a75baf) 65.16%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2135      +/-   ##
==========================================
+ Coverage   64.19%   65.16%   +0.97%     
==========================================
  Files         108      108              
  Lines       13919    13919              
==========================================
+ Hits         8935     9071     +136     
+ Misses       4110     3950     -160     
- Partials      874      898      +24     

Flag	Coverage Δ
e2e-test	37.37% <ø> (ø)
e2e-test-oncluster	30.53% <ø> (+<0.01%)	⬆️
e2e-test-oncluster-runtime	26.82% <ø> (?)
e2e-test-runtime-go	25.57% <ø> (?)
e2e-test-runtime-node	26.57% <ø> (?)
e2e-test-runtime-python	26.57% <ø> (?)
e2e-test-runtime-quarkus	26.68% <ø> (?)
e2e-test-runtime-rust	25.57% <ø> (?)
e2e-test-runtime-springboot	25.71% <ø> (?)
integration-tests	51.82% <ø> (+1.96%)	⬆️
unit-tests-macos-latest	48.85% <ø> (ø)
unit-tests-ubuntu-latest	49.59% <ø> (ø)
unit-tests-windows-latest	48.86% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matejvasek]

I thought that the directive was added by codegen 😄 .

[dsimansk]

I thought that the directive was added by codegen 😄 .

Well, the chain looks like the following. Firstly, it's added through go mod tidy whenever go 1.21 module is pulled. go mod tidy is executed after buoy recognize new knative version thingy. Then our homegrown buoy tool stops actually working. I.e. silenty preventing any more auto updates.

knative/toolbox#24