Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: host builder metadata envs #2195

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

lkingland
Copy link
Member

Changes

  • 🎁 host builder supports setting static metadata envs on resultant container

For now, this includes FUNC_CREATED and FUNC_VERSION to assist with current debugging and versioning efforts.

Should these prove useful, we should add them to containers built with Pack and S2I as well.

/kind enhancement

Fixes #

Release Note

Functions built with the experimental "Host" builder include FUNC_CREATED and FUNC_VERSION metadata environment variables.

Docs


@knative-prow knative-prow bot added kind/enhancement approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 29, 2024
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 29, 2024
@lkingland lkingland requested review from gauron99 and removed request for navidshaikh and dsimansk February 29, 2024 08:28
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
Copy link

knative-prow bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ab2bbff into knative:main Mar 1, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants